From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24601 invoked by alias); 10 Oct 2011 21:56:54 -0000 Received: (qmail 24593 invoked by uid 22791); 10 Oct 2011 21:56:53 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Oct 2011 21:56:39 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RDNpu-0004eu-Tf from pedro_alves@mentor.com ; Mon, 10 Oct 2011 14:56:39 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 10 Oct 2011 22:56:36 +0100 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch] New test+use texinfo @click - @HAVE_MAKEINFO_CLICK@ [Re: doc build failure (Re: [patch 04/12] entryval#3: Virtual tail call frames)] Date: Mon, 10 Oct 2011 21:56:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.1; x86_64; ; ) Cc: gdb-patches@sourceware.org, Ulrich Weigand , eliz@gnu.org References: <201110101651.00816.pedro@codesourcery.com> <20111010184726.GA14706@host1.jankratochvil.net> In-Reply-To: <20111010184726.GA14706@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110102256.34728.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00289.txt.bz2 On Monday 10 October 2011 19:47:26, Jan Kratochvil wrote: > + if makeinfo conftest.texinfo >&5 2>&5; then Shouldn't this be $(MAKEINFO) instead (like in Makefile.in)? Though I'm not sure how to do that here. Maybe AC_CHECK_PROGS(MAKEINFO, makeinfo) ? > +if test x"$gdb_cv_have_makeinfo_click" = xyes; then > + HAVE_MAKEINFO_CLICK="-DHAVE_MAKEINFO_CLICK" > +else > + HAVE_MAKEINFO_CLICK="" > +fi > +AC_SUBST(HAVE_MAKEINFO_CLICK) AC_DEFINE is usualy better for predicate defines, such as HAVE_FOOS. But in this is case, I think it's the variable's name that is confusing. It should be somethink like MAKEINFO_EXTRA_FLAGS. (MAKEINFOFLAGS is the moral equivalent of CFLAGS, so we should leave it reserved for the user.) if test x"$gdb_cv_have_makeinfo_click" = xyes; then MAKEINFO_EXTRA_FLAGS="-DHAVE_MAKEINFO_CLICK" else MAKEINFO_EXTRA_FLAGS="" fi MAKEINFO=makeinfo @MAKEINFO_EXTRA_FLAGS@ Thanks! -- Pedro Alves