From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] testsuite: Add a test for passing of environment variables to inferior
Date: Fri, 07 Oct 2011 12:26:00 -0000 [thread overview]
Message-ID: <20111007122544.GB9870@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20111006150256.GA26438@calimero.vinschen.de>
On Thu, Oct 06, 2011 at 05:02:56PM +0200, Corinna Vinschen wrote:
>On Oct 6 10:51, Christopher Faylor wrote:
>> Why not just check if CW_CVT_ENV_TO_WINENV is defined rather than checking
>> specifically for a version number? Checking arbitrary versions like this
>> should be a last resort.
>
>The CW_foo values are not macros, but enum values. You can't check
>them for being defined.
>
>Possible workaround is to define them twice, once as enum and once
>as macro, just as Linux does or just as some Cygwin headers do,
>for instance <cygwin/in.h>:
>
> enum
> {
> IPPROTO_IP = 0, /* Dummy protocol for TCP */
> IPPROTO_HOPOPTS = 0, /* IPv6 Hop-by-Hop options */
> [...]
> };
>
> #define IPPROTO_IP IPPROTO_IP
> #define IPPROTO_HOPOPTS IPPROTO_HOPOPTS
> [...]
>
>If we do that in <sys/cygwin.h> as well, I can change the test to
>#ifdef CW_CVT_ENV_TO_WINENV. What do you think?
Ok.
cgf
next prev parent reply other threads:[~2011-10-07 12:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 12:36 Pierre Muller
2011-10-04 13:45 ` Corinna Vinschen
2011-10-04 14:43 ` Eli Zaretskii
2011-10-04 14:48 ` Pierre Muller
2011-10-04 14:50 ` Pierre Muller
2011-10-04 15:13 ` Corinna Vinschen
2011-10-04 16:09 ` [RFA-v2] " Pierre Muller
2011-10-04 16:11 ` [RFA] " Pierre Muller
2011-10-05 11:40 ` Corinna Vinschen
2011-10-05 12:08 ` Pierre Muller
2011-10-05 12:52 ` Corinna Vinschen
2011-10-06 14:51 ` Christopher Faylor
2011-10-06 15:03 ` Corinna Vinschen
2011-10-07 12:26 ` Christopher Faylor [this message]
2011-10-07 13:53 ` Corinna Vinschen
[not found] ` <12954.5351061553$1317744599@news.gmane.org>
2011-10-04 17:27 ` [RFA-v2] " Tom Tromey
2011-10-04 21:35 ` [RFA-v3] " Pierre Muller
[not found] ` <29288.743020925$1317764135@news.gmane.org>
2011-10-05 13:53 ` Tom Tromey
2011-10-05 14:25 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007122544.GB9870@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox