Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
	Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [patch 3/3] Implement qXfer:libraries for Linux/gdbserver #2
Date: Thu, 06 Oct 2011 19:09:00 -0000	[thread overview]
Message-ID: <201110062009.24796.pedro@codesourcery.com> (raw)
In-Reply-To: <20111003215530.GC20272@host1.jankratochvil.net>

I think this is great,

On Monday 03 October 2011 22:55:30, Jan Kratochvil wrote:
>  should instead include a list of allocated sections.  The segment or
>  section bases are start addresses, not relocation offsets; they do not
> -depend on the library's link-time base addresses.
> +depend on the library's link-time base addresses.  For SVR4 systems
> +are reported parameters @{lm} with address of @code{struct link_map}
> +used for TLS (Thread Local Storage) access, @code{l_addr} specifying
> +bias of the mapped memory address minus the prelinked base address
> +and also @code{l_ld} which is memory address of the @code{PT_DYNAMIC}
> +segment.  SVR4 systems additionally specify @code{struct link_map}
> +address of the main executable in the @code{<library-list>} element.

but this reuse of <library-list> is a mistake.  If we're not going to use
an solib-target.c at all, and the semantics of what goes over the
wire is not the same as <library-list>/TARGET_OBJECT_LIBRARIES, then
let's come up with a completely independent new target object + dtd
instead.  Let's call it for example TARGET_OBJECT_SVR4_LIBRARIES.
We should not prevent the possibility of _both_ using
solib-svr4.c and solib-target.c at the same time, or the
possibility of having a completely target-side implementation
of svr4 libraries in the future, using <library-list> as is
(and having gdb be aware that support is present from
qXfer:read:libraries+ in qSupported).

-- 
Pedro Alves


  parent reply	other threads:[~2011-10-06 19:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-03 21:55 Jan Kratochvil
2011-10-04  6:11 ` Eli Zaretskii
2011-10-18 17:49   ` Messages localization in gdbserver [Re: [patch 3/3] Implement qXfer:libraries for Linux/gdbserver #2] Jan Kratochvil
2011-10-06 19:09 ` Pedro Alves [this message]
2011-10-21 11:05   ` [patch 3/3] Implement qXfer:libraries for Linux/gdbserver #2 Jan Kratochvil
2011-10-21 13:32     ` Pedro Alves
2011-11-03 21:30       ` [patch] Implement qXfer:libraries-svr4 for Linux/gdbserver #4 Jan Kratochvil
2011-12-02 22:33         ` [commit] " Jan Kratochvil
2011-12-03 17:03           ` Doug Evans
2011-12-03 18:34             ` [commit] Fix compilation --without-expat [Re: [commit] [patch] Implement qXfer:libraries-svr4 for Linux/gdbserver #4] Jan Kratochvil
2011-10-10  2:44 ` [patch 3/3] Implement qXfer:libraries for Linux/gdbserver #2 Daniel Jacobowitz
2011-10-12 20:22   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110062009.24796.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox