From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27516 invoked by alias); 16 Sep 2011 14:57:35 -0000 Received: (qmail 27508 invoked by uid 22791); 16 Sep 2011 14:57:35 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_CL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Sep 2011 14:57:19 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1R4Zqv-0007Ho-Op from pedro_alves@mentor.com ; Fri, 16 Sep 2011 07:57:17 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 16 Sep 2011 15:57:15 +0100 From: Pedro Alves To: Tristan Gingold Subject: Re: [RFA] Preliminary work in fork_inferior Date: Fri, 16 Sep 2011 15:28:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; ) Cc: "gdb-patches@sourceware.org ml" References: <201109161419.55173.pedro@codesourcery.com> <49D8FDB6-8E7E-46F1-B2FE-DABF6697B87D@adacore.com> In-Reply-To: <49D8FDB6-8E7E-46F1-B2FE-DABF6697B87D@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109161557.12334.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00308.txt.bz2 On Friday 16 September 2011 15:47:19, Tristan Gingold wrote: > > On Sep 16, 2011, at 3:19 PM, Pedro Alves wrote: > > > Thanks, this is okay. > > > > On Friday 16 September 2011 13:28:59, Tristan Gingold wrote: > >> + /* If we get here, it's an error. */ > >> if (shell) > >> { > >> - execlp (shell_file, shell_file, "-c", shell_command, (char *) 0); > >> - > >> - /* If we get here, it's an error. */ > >> fprintf_unfiltered (gdb_stderr, "Cannot exec %s: %s.\n", shell_file, > >> safe_strerror (errno)); > > > > I wouldn't mind merging the "Cannot exec" bits of both branches as well, > > always printing the whole argv. > > Ok, so more cleanup. Something like that ? Looks greak, thanks! Please apply. -- Pedro Alves