From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83718-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28621 invoked by alias); 16 Sep 2011 12:26:44 -0000
Received: (qmail 28613 invoked by uid 22791); 16 Sep 2011 12:26:43 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Sep 2011 12:26:15 +0000
Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com)	by relay1.mentorg.com with esmtp 	id 1R4XUk-00026L-8C from pedro_alves@mentor.com ; Fri, 16 Sep 2011 05:26:14 -0700
Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830);	 Fri, 16 Sep 2011 13:26:11 +0100
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch 11/12] entryval#2: @entry values even for references
Date: Fri, 16 Sep 2011 12:29:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; )
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
References: <20110913195046.GL12849@host1.jankratochvil.net>
In-Reply-To: <20110913195046.GL12849@host1.jankratochvil.net>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201109161326.09350.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-09/txt/msg00298.txt.bz2

On Tuesday 13 September 2011 20:50:47, Jan Kratochvil wrote:
> +             struct value *deref_val;
> +
> +             deref_val = coerce_ref_if_computed (original_value);

Hmm, this doesn't look right.  It ignores embedded_offset.  What if the reference
we're currently printing is a field of a struct at offset != 0?
E.g., `struct { long l; long &r } foo;', and we're `p foo', which descends
into printing R at FOO + offset of R ?

> +             if (deref_val)
> +               {
> +                 common_val_print (deref_val, stream, recurse, options,
> +                                   current_language);
> +                 return 0;
> +               }
> +
> +             deref_val = value_at (TYPE_TARGET_TYPE (type),
> +                                   unpack_pointer (type,
> +                                                   valaddr + embedded_offset));

-- 
Pedro Alves