Re: [RFC 06/12] entryval: Display @entry parameters in bt full

Eli Zaretskii
2011-07-19T11:14:39Z

> Date: Tue, 19 Jul 2011 12:30:55 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
>
> GDB internally knows the value of the parameter at the function entry - to be
> able to recover the values. It has been found out the developers may find it
> useful to be shown the entry values it. It is an additional feature on top of
> the values recovery.

But then why don't we just show the value at entry in the function
call line? IOW, show this:

#8 0x000000000048c50d in execute_command (p=0x22b5720 "maintenance internal-error", from_tty=1) at top.c:438

instead of this:

#8 0x000000000048c50d in execute_command (p=0x22b573b "", from_tty=1) at top.c:438
p@entry = 0x22b5720 "maintenance internal-error "

Also show those entry-time values in "info args", as you already
suggested.

This will also fix the annoyance I sometimes bump into, whereby if I
type "bt" some time after stepping into a function, the values of the
parameters are not necessarily those that were actual at the time of
the call (if the function modifies them).

> I think it is separated well enough in the patchset, up to incl. 05/12 it is
> about values recovery, from 06/12 it is about user-accessible entry values.

Sorry, I didn't read the code, only the doco parts and the general
discussion.

Thanks.