From: Pedro Alves <pedro@codesourcery.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: Watchpoint resource accounting broken (Re: [5/6] breakpoints_ops for all kinds of breakpoints: new watchpoints instance type
Date: Tue, 13 Sep 2011 17:20:00 -0000 [thread overview]
Message-ID: <201109131749.03424.pedro@codesourcery.com> (raw)
In-Reply-To: <201109131522.p8DFMg93032568@d06av02.portsmouth.uk.ibm.com>
On Tuesday 13 September 2011 16:22:42, Ulrich Weigand wrote:
> Pedro Alves wrote:
> > Does the patch below work? Never consider the current watchpoint when
> > going over the breakpoint list counting resources, and then
> > add the resources of the current watchpoint on top. This way we
> > don't have to care of the current watchpoint being on the list yet or
> > not. As bonus, we no longer have to frog the watchpoint's type before
> > knowing if it'll fit.
>
> Yes, this patch looks good to me, and does fix the problem I've
> been seeing. Thanks!
Thanks to both. I've checked it in now.
> It seems to me that it would be preferable to integrate these missing
> checks into the code in update_watchpoint, and then remove the
> can_use_hardware_watchpoint routine ...
Indeed.
> [ But that's clearly a follow-on cleanup, and shouldn't prevent your
> bug-fix patch from going in now. ]
Yep.
--
Pedro Alves
prev parent reply other threads:[~2011-09-13 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 15:58 Pedro Alves
2011-07-27 10:11 ` Edjunior Barbosa Machado
2011-09-12 15:06 ` Watchpoint resource accounting broken (Re: [5/6] breakpoints_ops for all kinds of breakpoints: new watchpoints instance type) Ulrich Weigand
2011-09-12 15:17 ` Pedro Alves
2011-09-12 15:23 ` Edjunior Barbosa Machado
2011-09-13 14:16 ` Pedro Alves
2011-09-13 14:42 ` Edjunior Barbosa Machado
2011-09-13 14:54 ` Pedro Alves
2011-09-13 16:49 ` Watchpoint resource accounting broken (Re: [5/6] breakpoints_ops for all kinds of breakpoints: new watchpoints instance type Ulrich Weigand
2011-09-13 17:20 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109131749.03424.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox