From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13017 invoked by alias); 12 Sep 2011 15:23:24 -0000 Received: (qmail 13006 invoked by uid 22791); 12 Sep 2011 15:23:23 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Sep 2011 15:23:08 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1R38Lj-0003mF-H6 from pedro_alves@mentor.com ; Mon, 12 Sep 2011 08:23:07 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 12 Sep 2011 16:23:05 +0100 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Some code-cleanup Date: Mon, 12 Sep 2011 15:30:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; ) Cc: Abhijit Halder References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201109121623.04292.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00197.txt.bz2 On Monday 12 September 2011 16:05:59, Abhijit Halder wrote: > I have seen in one place (write_exp_elt) that we are passing an union > by value and not by reference. > Please let me know whether we do have any specific reason of doing > that. I am submitting the patch as an attachment. Please review the > same. > See : --0016364d2c7965a8ac04acbfddf0 Content-Type: application/octet-stream; name=patch Content-Disposition: attachment; filename=patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_gshl4bmu0 Please teach your browser to attach files to gmail as some text based content type, like patch/diff or text/x-patch. It may just be a matter of renaming the files to have a ".diff" or ".patch" extension before attaching them. If not, you may need to teach your browser about the mime type of .diff/.patch. You can see which mime type gmail gives your patch before actually sending the email. Just let gmail complete the patch upload, and you should then see something like [X] foo.diff (text/x-patch) 5K It also affects the mail archives, check the difference, both sent from gmail with files attached: (follow the "Raw text" link too) -- Pedro Alves