From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10377 invoked by alias); 8 Sep 2011 15:54:00 -0000 Received: (qmail 10369 invoked by uid 22791); 8 Sep 2011 15:53:58 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 15:53:38 +0000 Received: from nat-dem.mentorg.com ([195.212.93.2] helo=eu2-mail.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1R1gv4-0002wB-3x from pedro_alves@mentor.com ; Thu, 08 Sep 2011 08:53:38 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by eu2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 8 Sep 2011 17:53:36 +0200 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target Date: Thu, 08 Sep 2011 15:57:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; ) Cc: Jan Kratochvil , Mark Kettenis , hjl.tools@gmail.com References: <20110826092539.GA23720@host1.jankratochvil.net> <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> <20110908153454.GE23706@host1.jankratochvil.net> In-Reply-To: <20110908153454.GE23706@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109081653.34529.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00142.txt.bz2 On Thursday 08 September 2011 16:34:54, Jan Kratochvil wrote: > On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote: > > > From: Jan Kratochvil > > > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*. > > > > Uh, that's wrong. The middle part if the target triplet is supposed > > to be the hardware vendor. For i386/amd64 this is pretty much > > meaningles, but attaching a new meaning to it would be a mistake. > > > > Fortunately, your diff doesn't really depend on this. But I think you > > should adjust the comments in the code. > > The triple x86_64-x32-linux* is a reality in binutils, gcc etc., I believe if > it should be changed GDB is not the place to start such change. I don't believe that triplet was ever accepted. At least I don't see it in mainline src/ anywhere. GDB trunk itself doesn't support x32 yet. If there were bits that depended on the triplet, they'd be appropriate on the x32 branch instead, not in trunk yet. > And the comments should reflect the reality. > > OK to check it in as is? > > > Thanks, > Jan > -- Pedro Alves