From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12713 invoked by alias); 8 Sep 2011 15:57:33 -0000 Received: (qmail 12702 invoked by uid 22791); 8 Sep 2011 15:57:31 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_SV X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 15:57:14 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id p88Fv5cP026315; Thu, 8 Sep 2011 17:57:05 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id p88Fv4Yh010560; Thu, 8 Sep 2011 17:57:04 +0200 (CEST) Date: Thu, 08 Sep 2011 16:01:00 -0000 Message-Id: <201109081557.p88Fv4Yh010560@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: jan.kratochvil@redhat.com CC: hjl.tools@gmail.com, gdb-patches@sourceware.org In-reply-to: <20110908153454.GE23706@host1.jankratochvil.net> (message from Jan Kratochvil on Thu, 8 Sep 2011 17:34:54 +0200) Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target References: <20110826092539.GA23720@host1.jankratochvil.net> <20110828200640.GA10351@host1.jankratochvil.net> <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> <20110908153454.GE23706@host1.jankratochvil.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00143.txt.bz2 > Date: Thu, 8 Sep 2011 17:34:54 +0200 > From: Jan Kratochvil > > On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote: > > > From: Jan Kratochvil > > > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*. > > > > Uh, that's wrong. The middle part if the target triplet is supposed > > to be the hardware vendor. For i386/amd64 this is pretty much > > meaningles, but attaching a new meaning to it would be a mistake. > > > > Fortunately, your diff doesn't really depend on this. But I think you > > should adjust the comments in the code. > > The triple x86_64-x32-linux* is a reality in binutils, gcc etc., Where? Neither the config.guess/config.sub in the gcc svn repo, nor the one in the src cvs repo will ever return such a triplet. > And the comments should reflect the reality. Not my reality.