From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22665 invoked by alias); 8 Sep 2011 14:56:14 -0000 Received: (qmail 22657 invoked by uid 22791); 8 Sep 2011 14:56:13 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 14:55:55 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p88EtsxX031813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Sep 2011 10:55:54 -0400 Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p88EtoNM006989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 8 Sep 2011 10:55:52 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p88EtoKV026073; Thu, 8 Sep 2011 16:55:50 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p88EtnYD026069; Thu, 8 Sep 2011 16:55:49 +0200 Date: Thu, 08 Sep 2011 14:59:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] Code cleanup: Split value_of_this to &{,_silent} Message-ID: <20110908145549.GA23706@host1.jankratochvil.net> References: <20110831155801.GA16329@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00135.txt.bz2 On Wed, 31 Aug 2011 18:06:35 +0200, Tom Tromey wrote: > Looks good to me. I prefer this style as well, "complain"-like > arguments make the API weird to use. Checked in: http://sourceware.org/ml/gdb-cvs/2011-09/msg00041.html Thanks, Jan