From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83415-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17509 invoked by alias); 31 Aug 2011 18:23:34 -0000
Received: (qmail 17496 invoked by uid 22791); 31 Aug 2011 18:23:33 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 18:23:14 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7VINEEm005149	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 31 Aug 2011 14:23:14 -0400
Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7VINCMY006093	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Wed, 31 Aug 2011 14:23:13 -0400
Received: from host1.jankratochvil.net (localhost [127.0.0.1])	by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7VINBxq014536;	Wed, 31 Aug 2011 20:23:11 +0200
Received: (from jkratoch@localhost)	by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7VINAGt014528;	Wed, 31 Aug 2011 20:23:10 +0200
Date: Wed, 31 Aug 2011 18:23:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] 12843
Message-ID: <20110831182310.GA14153@host1.jankratochvil.net>
References: <4E56C5A0.60802@redhat.com> <m34o14t4la.fsf@fleche.redhat.com> <4E5E7AA1.5030209@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E5E7AA1.5030209@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00675.txt.bz2

On Wed, 31 Aug 2011 20:17:05 +0200, Keith Seitz wrote:
> -	  || p[0] == '\t'
> -	  || (p[0] == ':')
> +	  || p[0] == '\t' || p[0] == ':'

This is code cleanup outside of the scope of this patch (but OK).


> +if {[prepare_for_testing linespecs.exp memattr memattr.c {debug}]} {
  +if [prepare_for_testing linespecs.exp linespecs memattr.c] {

The testcase linespecs.exp should have binary linespecs, no matter from which
sources it was created.  (I really do not mind {debug} or not.)


Thanks,
Jan