From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10218 invoked by alias); 26 Aug 2011 01:48:03 -0000 Received: (qmail 10034 invoked by uid 22791); 26 Aug 2011 01:48:02 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 01:47:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BA7232BB455; Thu, 25 Aug 2011 21:47:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8HjfqLZ4KJpj; Thu, 25 Aug 2011 21:47:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 825352BB3D3; Thu, 25 Aug 2011 21:47:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 13A88145615; Thu, 25 Aug 2011 21:47:42 -0400 (EDT) Date: Fri, 26 Aug 2011 01:48:00 -0000 From: Joel Brobecker To: Marc Khouzam Cc: 'Tom Tromey' , "'gdb-patches@sourceware.org'" Subject: Re: [patch] Tweak output of -var-info-path-expression Message-ID: <20110826014742.GA2843@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00475.txt.bz2 > 2011-08-23 Marc Khouzam > > PR mi/11912 > * varobj.c (cplus_describe_child): Add the keyword > 'class' to the output of the method when dealing > with a cast to a base class. > > 2011-08-23 Marc Khouzam > > PR mi/11912 > * gdb.mi/mi-inheritance-syntax-error.cc: New file. > * gdb.mi/mi-inheritance-syntax-error.exp: New file. > * gdb.mi/mi-var-cp.cc: Updated for new 'class' > keyword in output of -var-info-path-expression. [...] > Do you think it is ok for the 7.3 branch? No objection for putting it on 7.3 since Tom thinks it's OK. One nit: > + When we are in the scope of the base class or of one > + of its children, the type field name will be interpreted > + as a constructor, if it exists. Therefore, we must > + indicate that the name is a class name by using the > + 'class' keyword. PR mi/11912 */ ^^^^ Missing second space after a period. I would also follow the general GCS guideline that everything is a setence, and thus write something like: `[...] keyword. See PR mi/11912. */'. But that's only if you agree, it can be seen as a matter of preference. -- Joel