From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23008 invoked by alias); 24 Aug 2011 19:04:43 -0000 Received: (qmail 22999 invoked by uid 22791); 24 Aug 2011 19:04:41 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_WH X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Aug 2011 19:04:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7OJ4OJV001379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Aug 2011 15:04:24 -0400 Received: from host1.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7OJ4MAg028165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 24 Aug 2011 15:04:24 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7OJ4Lsc013326; Wed, 24 Aug 2011 21:04:21 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7OJ4K0v013324; Wed, 24 Aug 2011 21:04:20 +0200 Date: Wed, 24 Aug 2011 19:04:00 -0000 From: Jan Kratochvil To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 6/7] New JIT unwinder. Message-ID: <20110824190420.GA12935@host1.jankratochvil.net> References: <1314212467-7391-1-git-send-email-sanjoy@playingwithpointers.com> <1314212467-7391-7-git-send-email-sanjoy@playingwithpointers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1314212467-7391-7-git-send-email-sanjoy@playingwithpointers.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00458.txt.bz2 On Wed, 24 Aug 2011 21:01:06 +0200, Sanjoy Das wrote: > Introduce a "proxy unwinder", whcih will pass down all calls to the > functions the JIT reader provides. Still incorrect assumptions target_gdbarch == get_frame_arch (frame). You should use get_frame_arch (frame) instead. While it currently affects only SPU if GDB supports one day across-RPC (remote procedure calls in general) debugging it woule be also a problem. OTOH I guess there are probably already some places not conforming to this. Thanks, Jan