From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30459 invoked by alias); 15 Aug 2011 07:57:49 -0000 Received: (qmail 30438 invoked by uid 22791); 15 Aug 2011 07:57:48 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Aug 2011 07:57:07 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7F7v7Fc021086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Aug 2011 03:57:07 -0400 Received: from host1.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7F7v5T2006569 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 15 Aug 2011 03:57:07 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7F7v4Lt029368 for ; Mon, 15 Aug 2011 09:57:04 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7F7v3Vs029366 for gdb-patches@sourceware.org; Mon, 15 Aug 2011 09:57:03 +0200 Date: Mon, 15 Aug 2011 07:57:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [obv] testsuite: read1 fix: gdb.arch/i386-dr3-watch.exp Message-ID: <20110815075703.GA29081@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00295.txt.bz2 Hi Pedro, with "read1" runtest [Bug testsuite/12649] New: reproducer for races of expect incomplete reads http://sourceware.org/bugzilla/show_bug.cgi?id=12649 and therefore occasionally even during normal runs it will: FAIL: gdb.arch/i386-dr3-watch.exp: watch i1 still fits (got interactive prompt) FAIL: gdb.arch/i386-dr3-watch.exp: watch i2 still fits FAIL: gdb.arch/i386-dr3-watch.exp: watch i3 still fits FAIL: gdb.arch/i386-dr3-watch.exp: watch i4 still fits due to watch gap1 Hardware watchpoint 7: gap1 Warning: Could not insert hardware watchpoint 7. Could not insert hardware breakpoints: You may have requested too manyPASS: gdb.arch/i386-dr3-watch.exp: watchpoint on gap1 does not fit debug registers hardware breakpoints/watchpoints. (gdb) PASS: gdb.arch/i386-dr3-watch.exp: delete all watchpoints delete Delete all breakpoints? (y or n) watch i1 Please answer y or n. Delete all breakpoints? (y or n) n (gdb) FAIL: gdb.arch/i386-dr3-watch.exp: watch i1 still fits (got interactive prompt) Checked in. Tested on {x86_64,x86_64-m32}-fedora16pre-linux-gnu. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2011-08/msg00077.html --- src/gdb/testsuite/ChangeLog 2011/08/14 15:58:39 1.2834 +++ src/gdb/testsuite/ChangeLog 2011/08/15 07:56:20 1.2835 @@ -1,3 +1,9 @@ +2011-08-15 Jan Kratochvil + + * gdb.arch/i386-dr3-watch.exp + (watchpoint on gap1 does not fit debug registers) + (delete all watchpoints): Fix racy expect strings. + 2011-08-14 Yao Qi * gdb.base/maint.exp: set data_section to ".neardata". --- src/gdb/testsuite/gdb.arch/i386-dr3-watch.exp 2011/07/22 16:58:32 1.2 +++ src/gdb/testsuite/gdb.arch/i386-dr3-watch.exp 2011/08/15 07:56:20 1.3 @@ -64,7 +64,7 @@ # 4 if all were available). set test "watchpoint on gap1 does not fit debug registers" gdb_test_multiple "watch gap1" "$test" { - -re "Hardware watchpoint .*: gap1.*Warning:.*Could not insert hardware watchpoint.*You may have requested too many.*" { + -re "Hardware watchpoint .*: gap1.*Warning:.*Could not insert hardware watchpoint.*You may have requested too many.*\r\n$gdb_prompt $" { pass $test } -re "Hardware watchpoint .*: gap1\r\n$gdb_prompt $" { @@ -81,7 +81,7 @@ gdb_test "delete" \ "" \ "delete all watchpoints" \ - "Delete all breakpoints.*$" \ + {Delete all breakpoints\? \(y or n\) $} \ "y" # If debug registers were left occupied by mistake, we'll fail to set