From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3868 invoked by alias); 13 Aug 2011 16:51:30 -0000 Received: (qmail 3858 invoked by uid 22791); 13 Aug 2011 16:51:29 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Aug 2011 16:51:16 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7DGpFRj000454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 13 Aug 2011 12:51:15 -0400 Received: from host1.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7DGpDwN023539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 13 Aug 2011 12:51:15 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7DGpDgL021409; Sat, 13 Aug 2011 18:51:13 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7DGpDHZ021404; Sat, 13 Aug 2011 18:51:13 +0200 Date: Sat, 13 Aug 2011 16:51:00 -0000 From: Jan Kratochvil To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] c++/12266 (again) [cp_demangled_name_parse_free-4.patch] Message-ID: <20110813165113.GB2217@host1.jankratochvil.net> References: <4E31EE1A.5040204@redhat.com> <20110802202825.GA13092@host1.jankratochvil.net> <4E419712.3070709@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E419712.3070709@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00273.txt.bz2 On Tue, 09 Aug 2011 22:22:42 +0200, Keith Seitz wrote: > ChangeLog > 2011-08-09 Keith Seitz > > * cp-name-parser.y (struct demangle_info): Remove unused > member PREV. > (d_grab): Likewise. > (allocate_info): Change return type to struct demangle_info *. > Always allocate a new demangle_info. > Remove unused PREV pointer. > (cp_new_demangle_parse_info): New function. > (cp_demangled_name_parse_free): New function. > (do_demangled_name_parse_free_cleanup): New function. > (make_cleanup_cp_demangled_name_parse_free): New function. > (cp_demangled_name_to_comp): Change return type to > struct demangle_parse_info *. > Allocate a new storage for each call. > (main): Update usage for cp_demangled_name_to_comp > API change. > * cp-support.h (struct demangle_parse_info): New structure. > (cp_demangled_name_to_comp): Update API change for > return type. > (cp_new_demangle_parse_info): Declare. > (make_cleanup_cp_demangled_name_parse_free): New declaration. > (cp_demangled_name_parse_free): Declare. > * cp-support.c (cp_canonicalize_string): Update API > change for cp_demangled_name_to_comp. > (mangled_name_to_comp): Likewise. > Return struct demangle_parse_info, too. > (cp_class_name_from_physname): Update mangled_name_to_comp > API change. > (method_name_from_physname): Likewise. > (cp_func_name): Update API change for cp_demangled_name_to_comp. > (cp_remove_params): Likewise. > * python/py-type.c (typy_legacy_template_argument): Likewise. I find it OK now. Thanks, Jan