From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82959-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31695 invoked by alias); 10 Aug 2011 14:08:28 -0000
Received: (qmail 31678 invoked by uid 22791); 10 Aug 2011 14:08:27 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Aug 2011 14:08:05 +0000
Received: (qmail 5457 invoked from network); 10 Aug 2011 14:08:05 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 10 Aug 2011 14:08:05 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver
Date: Wed, 10 Aug 2011 14:08:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-10-generic; KDE/4.7.0; x86_64; ; )
Cc: Yao Qi <yao@codesourcery.com>, Mark Kettenis <mark.kettenis@xs4all.nl>
References: <4E263865.2070100@codesourcery.com> <4E40A565.2020208@codesourcery.com> <201108101503.28057.pedro@codesourcery.com>
In-Reply-To: <201108101503.28057.pedro@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201108101508.03546.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00219.txt.bz2

On Wednesday 10 August 2011 15:03:27, Pedro Alves wrote:
> On Tuesday 09 August 2011 04:11:33, Yao Qi wrote:
> > 2011-08-09  Andrew Stubbs <ams@codesourcery.com>
> >             Yao Qi <yao@codesourcery.com>
> > 
> >         gdb/
> >         * remote.c (PACKET_qXfer_fdpic): New enum value.
> >         (remote_protocol_features): Add qXfer:fdpic:read packet.
> >         (remote_xfer_partial): Support TARGET_OBJECT_FDPIC.
> >         (_initialize_remote): Add set/show remote read-fdpic-loadmap command.
> >         * target.h (enum target_object): Add TARGET_OBJECT_FDPIC.
> > 
> >         gdb/gdbserver:
> >         * target.h (struct target_ops): Add read_loadmap.
> >         * linux-low.c (struct target_loadseg): New type.
> >         (struct target_loadmap): New type.
> >         (linux_read_loadmap): New function.
> >         (linux_target_ops): Add linux_read_loadmap.
> >         * server.c (handle_query): Support qXfer:fdpic:read packet.
> >         * win32-low.c (win32_target_ops): Initialize field `read_loadmap' to NULL.
> > 
> >         gdb/doc/
> >         * gdb.texinfo : Document qXfer:fdpic:read packet.
> 
> Thanks.  Looks good to me.

Oh, just one detail:

> +  /* Read loadmaps.  Read LEN bytes at OFFSET into a buffer at MYADDR.  */
> +  int (*read_loadmap) (const char *annex, CORE_ADDR offset,
> +                            unsigned char *myaddr, unsigned int len);

...

> +  NULL, /* read_fdpic_loadmap */

Please make those coincide though.

-- 
Pedro Alves