From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10426 invoked by alias); 10 Aug 2011 13:44:56 -0000 Received: (qmail 10417 invoked by uid 22791); 10 Aug 2011 13:44:55 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Aug 2011 13:44:39 +0000 Received: (qmail 31582 invoked from network); 10 Aug 2011 13:44:39 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Aug 2011 13:44:39 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA 5/8] New port: TI C6x: gdb port Date: Wed, 10 Aug 2011 13:44:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-10-generic; KDE/4.7.0; x86_64; ; ) Cc: Yao Qi References: <4E2638A6.1070406@codesourcery.com> <201108091641.52349.pedro@codesourcery.com> <4E41EEB3.8040400@codesourcery.com> In-Reply-To: <4E41EEB3.8040400@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108101444.36843.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00216.txt.bz2 On Wednesday 10 August 2011 03:36:35, Yao Qi wrote: > On 08/09/2011 11:41 PM, Pedro Alves wrote: > >>> > > > >>> > > You can't do that given the descriptions specify GNU/Linux osabi. > >>> > > There should be linux, and non-linux variants. > >>> > > > >> > > >> > Can't we get rid of osabi from xml description, and use them both for > >> > linux and non-linux? Similar to arm's target descriptions. > > We can, but that's a bit a step backwards. arm's descriptions don't > > set the osabi because the support for the osabi field element was added > > after the descriptions were. Having the target tell gdb the osabi makes > > a multi-target gdb (*) figure out the correct arch even if you don't > > specify an executable (for attach). > > I see, thanks for the explanation, Pedro. > > > I believe that with an xi:include, the linux xml file would be minimal. > > I reference the i386 xml files, and do the similar for tic6x. Copy > tic6x-{c62x,c64x,c64xp}.xml to tic6x-{c62x,c64x,c64xp}-linux.xml, and > add osabi in tic6x-*-linux.xml files. Generate corresponding *.c files > and *.data files. Thanks, sounds good. > In the new patch, linux target descriptions are initialized in > tic6x-linux-tdep.c:_initialize_tic6x_linux_tdep, and non-linux target > descriptions are initialized in tic6x-tdep.c:_initialize_tic6x_tdep. Patch looks good to me. -- Pedro Alves