Re: [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver

Pedro Alves
2011-08-08T13:32:13Z

On Monday 08 August 2011 03:46:29, Yao Qi wrote:
> @@ -1182,6 +1197,7 @@ static const struct qxfer qxfer_packets[] =
> { "statictrace", handle_qxfer_statictrace },
> { "threads", handle_qxfer_threads },
> { "traceframe-info", handle_qxfer_traceframe_info },
> + { "fdpic", handle_qxfer_fdpic},

Please keep the list alpha sorted.

> + memcpy (myaddr, ((char *)data) + offset, copy_length);

memcpy (myaddr, (char *) data + offset, copy_length);

> @@ -5112,6 +5172,11 @@ static struct target_ops linux_target_ops = {
> NULL,
> #endif
> linux_core_of_thread,
> +#if defined PT_GETDSBT
> + linux_read_loadmap,
> +#else
> + NULL,
> +#endif
> linux_process_qsupported,
> linux_supports_tracepoints,
> linux_read_pc,

Looks like you may be breaking all !tic6x ports. Either
put the new method at the end, or update all
struct target_ops instances to adjust for the new field.

Otherwise, with Mark's comments addressed, this looks
fine to me.

Is there any patch in the series missing review?

Please take care to apply the patches in a sequence
where none breaks the build, to avoid breaking bisects.

--
Pedro Alves