Re: [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver

Mike Frysinger
2011-08-08T00:30:32Z

[-- Attachment #1: Type: Text/Plain, Size: 678 bytes --]

On Monday, July 25, 2011 00:27:50 Yao Qi wrote:
> On 07/22/2011 10:16 AM, Mike Frysinger wrote:
> >> +#if defined __DSBT__
> >> +static int
> >
> > rather than being tied to the exec format that *gdbserver* is being
> > built as, shouldnt this be bound to the ptrace defines being available
> > ? how abut using "#ifdef PTRACE_GETDSBT" ?
>
> Yeah, that makes sense. Done.

i think you missed a spot. one place uses __DSBT__ while another uses
PTRACE_GETDSBT.

> + addr= (int) PTRACE_GETDSBT_EXEC;
> + else if (strcmp (annex, "interp") == 0)
> + addr =(int) PTRACE_GETDSBT_INTERP;

there needs to be one space before and after the "=" here
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]