From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30998 invoked by alias); 8 Aug 2011 13:32:13 -0000 Received: (qmail 30988 invoked by uid 22791); 8 Aug 2011 13:32:12 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_CP,TW_QX X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Aug 2011 13:31:59 +0000 Received: (qmail 10761 invoked from network); 8 Aug 2011 13:31:57 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Aug 2011 13:31:57 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver Date: Mon, 08 Aug 2011 13:32:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Yao Qi , Mike Frysinger References: <4E263865.2070100@codesourcery.com> <201108072030.02712.vapier@gentoo.org> <4E3F4E05.6010409@codesourcery.com> In-Reply-To: <4E3F4E05.6010409@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108081431.55165.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00142.txt.bz2 On Monday 08 August 2011 03:46:29, Yao Qi wrote: > @@ -1182,6 +1197,7 @@ static const struct qxfer qxfer_packets[] = > { "statictrace", handle_qxfer_statictrace }, > { "threads", handle_qxfer_threads }, > { "traceframe-info", handle_qxfer_traceframe_info }, > + { "fdpic", handle_qxfer_fdpic}, Please keep the list alpha sorted. > + memcpy (myaddr, ((char *)data) + offset, copy_length); memcpy (myaddr, (char *) data + offset, copy_length); > @@ -5112,6 +5172,11 @@ static struct target_ops linux_target_ops = { > NULL, > #endif > linux_core_of_thread, > +#if defined PT_GETDSBT > + linux_read_loadmap, > +#else > + NULL, > +#endif > linux_process_qsupported, > linux_supports_tracepoints, > linux_read_pc, Looks like you may be breaking all !tic6x ports. Either put the new method at the end, or update all struct target_ops instances to adjust for the new field. Otherwise, with Mark's comments addressed, this looks fine to me. Is there any patch in the series missing review? Please take care to apply the patches in a sequence where none breaks the build, to avoid breaking bisects. -- Pedro Alves