Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.

Sergio Durigan Junior
2011-08-10T17:54:54Z

Abhijit Halder <abhijit.k.halder@gmail.com> writes:

> I made the corrections suggested during code review.

Well, from my perspective I don't think I have anything else about the
patch. However, I have some questions:

1) I don't remember if you already answered that, but do you have a
copyright assignment (or have you started the process to obtain one)?

2) I believe you can start thinking about a testcase for this feature.
I am not sure how you would write this in order to test it on various
operating systems, but I think starting with GNU/Linux is OK for now.
You may want to take a look at the gdb/testsuite directory for some
examples.

3) I also believe that you can write the documentation part for this
patch. You will also have to write a NEWS entry.

Maybe you can wait a little more until some maintainer reply before
start steps 2 and 3. Anyway, it's good to start thinking about these
steps.

Regards,

Sergio.