From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82694-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10673 invoked by alias); 28 Jul 2011 15:34:09 -0000
Received: (qmail 10608 invoked by uid 22791); 28 Jul 2011 15:34:07 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 15:33:53 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 879EE2BB07F;	Thu, 28 Jul 2011 11:33:52 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id muRyCnhZ5MRb; Thu, 28 Jul 2011 11:33:52 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 13B272BB076;	Thu, 28 Jul 2011 11:33:52 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id A91F2145615; Thu, 28 Jul 2011 08:33:49 -0700 (PDT)
Date: Thu, 28 Jul 2011 16:36:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: iam ahal <hal9000ed2k@gmail.com>, gdb-patches@sourceware.org,	eliz@gnu.org, pmuldoon@redhat.com, pedro@codesourcery.com,	drow@false.org
Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
Message-ID: <20110728153349.GF5177@adacore.com>
References: <CAA18ubJ10sh3pPDLp4V44qY6r6hLU9RqyDi62KuAAtfXJY7Oug@mail.gmail.com> <834o33qlm9.fsf@gnu.org> <CAA18ubJZK7w51Bmwvy7xYXPvHf7e=bbRbdBOqNvZA-PrXJpUsA@mail.gmail.com> <E1Qdhn8-0000fE-TK@fencepost.gnu.org> <CAA18ubJAvwHt-sq8XN98PhC=LSFXPbcy4P1+AVic-G=MNE7R2A@mail.gmail.com> <CAA18ubLBZseSxqjWSk1jH7OeZi06K_o75HKc0CN-_iCAjQ5boA@mail.gmail.com> <83bowq6x7f.fsf@gnu.org> <CAA18ub+ox5kmHu=1qvMkwNfzbCxMdy3M4Z8eKuheaiqyjxJvEg@mail.gmail.com> <m3d3gu77uk.fsf@fleche.redhat.com> <m38vri77pm.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m38vri77pm.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00789.txt.bz2

> I think instead of 'strstr' as a test, you want strncmp, followed by a
> check to make sure that either the compilation directory ends with a
> directory separator, or the following character in the source file name
> is one.

Seems like filename_ncmp would be better?

(should we write a specific routine that checks whether a given
fullpath "starts with" a given directory name?)
-- 
Joel