From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29994 invoked by alias); 23 Jul 2011 17:42:48 -0000 Received: (qmail 29983 invoked by uid 22791); 23 Jul 2011 17:42:48 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 Jul 2011 17:42:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6NHgT0k028478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 23 Jul 2011 13:42:29 -0400 Received: from host1.jankratochvil.net (ovpn-116-20.ams2.redhat.com [10.36.116.20]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6NHgRbn014390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 23 Jul 2011 13:42:28 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p6NHgQkb020248; Sat, 23 Jul 2011 19:42:26 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p6NHgP03020247; Sat, 23 Jul 2011 19:42:25 +0200 Date: Sat, 23 Jul 2011 18:43:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [obv] Indent prototypes so they do not get into tags Message-ID: <20110723174225.GA19820@host1.jankratochvil.net> References: <20110713151946.GA12824@host1.jankratochvil.net> <201107231714.p6NHEB3T024856@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201107231714.p6NHEB3T024856@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00655.txt.bz2 On Sat, 23 Jul 2011 19:14:11 +0200, Mark Kettenis wrote: > > -static struct value * > > -dwarf2_evaluate_loc_desc_full (struct type *type, struct frame_info *frame, > > - const gdb_byte *data, unsigned short size, > > - struct dwarf2_per_cu_data *per_cu, > > - LONGEST byte_offset); > > +static struct value *dwarf2_evaluate_loc_desc_full (struct type *type, > > + struct frame_info *frame, > > + const gdb_byte *data, > > + unsigned short size, > > + struct dwarf2_per_cu_data *per_cu, > > + LONGEST byte_offset); > > Bleah, that last one really becomes unreadable this way. Isn't there > a better way to this by bending the GNU coding style rules slightly in > a different way? A agree it is ugly. GNU indent according to GCS (GNU Coding Standards): static struct value *dwarf2_evaluate_loc_desc_full (struct type *type, struct frame_info *frame, const gdb_byte * data, unsigned short size, struct dwarf2_per_cu_data *per_cu, LONGEST byte_offset); The other usual possibilitiesone can find in GDB sources are: static struct value * dwarf2_evaluate_loc_desc_full (struct type *type, struct frame_info *frame, const gdb_byte *data, unsigned short size, struct dwarf2_per_cu_data *per_cu, LONGEST byte_offset); or: static struct value *dwarf2_evaluate_loc_desc_full (struct type *type, struct frame_info *frame, const gdb_byte *data, unsigned short size, struct dwarf2_per_cu_data *per_cu, LONGEST byte_offset); I really do not mind which one, as long as dwarf2_evaluate_loc_desc_full is not in tags, none of the possibilities look as a clear win to me. Thanks, Jan