Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [obv] Indent prototypes so they do not get into tags
Date: Sat, 23 Jul 2011 18:38:00 -0000	[thread overview]
Message-ID: <201107231714.p6NHEB3T024856@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20110713151946.GA12824@host1.jankratochvil.net> (message from	Jan Kratochvil on Wed, 13 Jul 2011 17:19:46 +0200)

> Date: Wed, 13 Jul 2011 17:19:46 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> --- src/gdb/dwarf2loc.c	2011/07/12 21:16:47	1.120
> +++ src/gdb/dwarf2loc.c	2011/07/13 15:15:42	1.121
> @@ -44,15 +44,15 @@
>  
>  extern int dwarf2_always_disassemble;
>  
> -static void
> -dwarf_expr_frame_base_1 (struct symbol *framefunc, CORE_ADDR pc,
> -			 const gdb_byte **start, size_t *length);
> +static void dwarf_expr_frame_base_1 (struct symbol *framefunc, CORE_ADDR pc,
> +				     const gdb_byte **start, size_t *length);
>  
> -static struct value *
> -dwarf2_evaluate_loc_desc_full (struct type *type, struct frame_info *frame,
> -			       const gdb_byte *data, unsigned short size,
> -			       struct dwarf2_per_cu_data *per_cu,
> -			       LONGEST byte_offset);
> +static struct value *dwarf2_evaluate_loc_desc_full (struct type *type,
> +						    struct frame_info *frame,
> +						    const gdb_byte *data,
> +						    unsigned short size,
> +					      struct dwarf2_per_cu_data *per_cu,
> +						    LONGEST byte_offset);

Bleah, that last one really becomes unreadable this way.  Isn't there
a better way to this by bending the GNU coding style rules slightly in
a different way?


  reply	other threads:[~2011-07-23 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 15:58 Jan Kratochvil
2011-07-23 18:38 ` Mark Kettenis [this message]
2011-07-23 18:43   ` Jan Kratochvil
2011-07-24 20:26     ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107231714.p6NHEB3T024856@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox