From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82461-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21740 invoked by alias); 20 Jul 2011 17:55:37 -0000
Received: (qmail 21730 invoked by uid 22791); 20 Jul 2011 17:55:37 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_EG
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 17:55:14 +0000
Received: (qmail 941 invoked from network); 20 Jul 2011 17:55:13 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 20 Jul 2011 17:55:13 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver
Date: Wed, 20 Jul 2011 18:22:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; )
Cc: Yao Qi <yao@codesourcery.com>
References: <4E2638CE.7050205@codesourcery.com>
In-Reply-To: <4E2638CE.7050205@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201107201855.09188.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00556.txt.bz2

On Wednesday 20 July 2011 03:09:18, Yao Qi wrote:

> +static CORE_ADDR
> +tic6x_get_pc (struct regcache *regcache)
> +{
> +  union tic6x_register pc;
> +  collect_register_by_name (regcache, "PC", pc.buf);

Empty line missing after declaration.  At least one more instance.

> +int *tic6x_regmap;
> +
...
> +unsigned int tic6x_breakpoint;

Could be static?

>  s390-linux32-expedite = r14,r15,pswa
>  s390-linux64-expedite = r14l,r15l,pswa
>  s390x-linux64-expedite = r14,r15,pswa
> +tic6x-linux-expedite = A15,PC

Stupid question: is there a reason all register
names are all caps in C6x?

> +++ b/gdb/features/tic6x-linux.xml
> @@ -0,0 +1,12 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2010, 2011 Free Software Foundation, Inc.
> +
> +     Copying and distribution of this file, with or without modification,
> +     are permitted in any medium without royalty provided the copyright
> +     notice and this notice are preserved.  -->
> +
> +<!DOCTYPE target SYSTEM "gdb-target.dtd">
> +<target>
> +  <architecture>tic6x</architecture>

Since this is for linux only, add:

 <osabi>GNU/Linux</osabi>

> +  <xi:include href="tic6x-cpu.xml"/>
> +</target>

> +#elif defined(__TMS320C6X__)
> +#define PT_TEXT_ADDR     0x10000*4
> +#define PT_DATA_ADDR     0x10004*4
> +#define PT_TEXT_END_ADDR 0x10008*4

Surround with parens as principle to avoid precedence
surprises:

  #define PT_TEXT_ADDR     (0x10000*4)

> +<!DOCTYPE feature SYSTEM "gdb-target.dtd">
> +<feature name="org.gnu.gdb.tic6x.cpu">
> +  <reg name="A0" bitsize="32"/>
> +  <reg name="A1" bitsize="32"/>
> +  <reg name="A2" bitsize="32"/>

...

These are all general purpose, core registers, right?

Otherwise looks fine to me.

-- 
Pedro Alves