From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>,
Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [RFC][patch] Avoid repeated calls to solib_add on initial attach.
Date: Wed, 20 Jul 2011 17:36:00 -0000 [thread overview]
Message-ID: <201107201809.56890.pedro@codesourcery.com> (raw)
In-Reply-To: <CALoOobOnmiG4fnpWohxS6znfrH6VvgmgxB8RDucnChQqEgY8wQ@mail.gmail.com>
On Wednesday 20 July 2011 17:44:43, Paul Pluzhnikov wrote:
> On Wed, Jul 20, 2011 at 9:35 AM, Pedro Alves <pedro@codesourcery.com> wrote:
>
> >> qStr {addr},{maxlen},{terminator}
> ...
> > We considered a packet like this too, but decided that bumping
> > target_read_string first and seeing if anything breaks would be
> > better. Haven't heard back of any breakage or slowdown so far.
> > I propose we do the same upstream.
>
> But do you have any targets where reading individual words is slow?
You mean slower than reading ~16 words? I doubt there's any where
it matters over the latency saved for the current callers of
target_read_string. Maybe it would matter if target_read_string
and read_string were merged. I don't object to the new packet;
I'm merely suggesting avoiding work until proven necessary. The
idea is off course sound.
> I don't know about any such targets first-hand, but I've heard that
> JTAG reading could be exceedingly slow.
We use a bunch of different probes, and so do our customers. I
don't know offhand which are slow, but they're there for sure.
> Another possible alternative is to make this a run-time parameter:
> 'maintenance set string-read-size 64' or some such. Default to 64 and
> let JTAG people dial it down if it ever becomes a problem for them?
I don't envision this being necessary, but I've certainly been
wrong before...
--
Pedro Alves
next prev parent reply other threads:[~2011-07-20 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 20:58 Paul Pluzhnikov
2011-07-20 13:56 ` Gary Benson
2011-07-20 14:59 ` Pedro Alves
2011-07-20 16:15 ` Paul Pluzhnikov
2011-07-20 16:56 ` Pedro Alves
2011-07-20 16:59 ` Paul Pluzhnikov
2011-07-20 17:36 ` Pedro Alves [this message]
2011-07-20 18:38 ` Pedro Alves
2011-07-22 17:27 ` Paul Pluzhnikov
2011-07-22 17:51 ` Pedro Alves
2011-07-22 17:36 ` Tom Tromey
2011-07-22 17:43 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107201809.56890.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox