From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [RFC][patch] Allow user to disable tracepoint support in gdbserver via command line
Date: Tue, 19 Jul 2011 18:44:00 -0000 [thread overview]
Message-ID: <201107191928.23553.pedro@codesourcery.com> (raw)
In-Reply-To: <20110719174427.D9BC3190BC8@elbrus2.mtv.corp.google.com>
On Tuesday 19 July 2011 18:44:27, Paul Pluzhnikov wrote:
> Greetings,
>
> Following up on my earlier "slow on high-latency links" message:
> http://sourceware.org/ml/gdb-patches/2011-07/msg00391.html ...
>
> Another source of major slowness for me is the gdbserver querying for
> tracepoint symbols.
>
> I see repeated (for each SOLIB) sequences of:
>
> 00:00:44 Sending packet: $qSymbol::#5b...Packet received: qSymbol:6764625f6167656e745f6764625f74705f686561705f627566666572
> 00:00:44 Packet qSymbol (symbol-lookup) is supported
> 00:00:44 Sending packet: $qSymbol::6764625f6167656e745f6764625f74705f686561705f627566666572#1e...Packet received: qSymbol:6764625f6167656e745f6764625f6a756d705f7061645f627566666572
> 00:00:44 Sending packet: $qSymbol::6764625f6167656e745f6764625f6a756d705f7061645f627566666572#e1...Packet received: qSymbol:6764625f6167656e745f6764625f6a756d705f7061645f6275666665725f656e64
> 00:00:44 Sending packet: $qSymbol::6764625f6167656e745f6764625f6a756d705f7061645f6275666665725f656e64#ec...Packet received: qSymbol:6764625f6167656e745f636f6c6c656374696e67
> 00:00:44 Sending packet: $qSymbol::6764625f6167656e745f636f6c6c656374696e67#02...Packet received: qSymbol:6764625f6167656e745f6764625f636f6c6c656374
> 00:00:45 Sending packet: $qSymbol::6764625f6167656e745f6764625f636f6c6c656374#65...Packet received: qSymbol:6764625f6167656e745f73746f705f74726163696e67
> 00:00:45 Sending packet: $qSymbol::6764625f6167656e745f73746f705f74726163696e67#a3...Packet received: qSymbol:6764625f6167656e745f666c7573685f74726163655f627566666572
> 00:00:45 Sending packet: $qSymbol::6764625f6167656e745f666c7573685f74726163655f627566666572#23...Packet received: qSymbol:6764625f6167656e745f61626f75745f746f5f726571756573745f6275666665725f7370616365
> 00:00:45 Sending packet: $qSymbol::6764625f6167656e745f61626f75745f746f5f726571756573745f6275666665725f7370616365#3e...Packet received: qSymbol:6764625f6167656e745f74726163655f6275666665725f69735f66756c6c
> 00:00:45 Sending packet: $qSymbol::6764625f6167656e745f74726163655f6275666665725f69735f66756c6c#58...Packet received: qSymbol:6764625f6167656e745f73746f7070696e675f7472616365706f696e74
> 00:00:45 Sending packet: $qSymbol::6764625f6167656e745f73746f7070696e675f7472616365706f696e74#ed...Packet received: qSymbol:6764625f6167656e745f657870725f6576616c5f726573756c74
> 00:00:46 Sending packet: $qSymbol::6764625f6167656e745f657870725f6576616c5f726573756c74#7b...Packet received: qSymbol:6764625f6167656e745f6572726f725f7472616365706f696e74
> 00:00:46 Sending packet: $qSymbol::6764625f6167656e745f6572726f725f7472616365706f696e74#79...Packet received: qSymbol:6764625f6167656e745f7472616365706f696e7473
> 00:00:46 Sending packet: $qSymbol::6764625f6167656e745f7472616365706f696e7473#06...Packet received: qSymbol:6764625f6167656e745f74726163696e67
> 00:00:46 Sending packet: $qSymbol::6764625f6167656e745f74726163696e67#30...Packet received: qSymbol:6764625f6167656e745f74726163655f6275666665725f6374726c
> 00:00:46 Sending packet: $qSymbol::6764625f6167656e745f74726163655f6275666665725f6374726c#b0...Packet received: qSymbol:6764625f6167656e745f74726163655f6275666665725f6374726c5f63757272
> 00:00:46 Sending packet: $qSymbol::6764625f6167656e745f74726163655f6275666665725f6374726c5f63757272#f2...Packet received: qSymbol:6764625f6167656e745f74726163655f6275666665725f6c6f
> 00:00:47 Sending packet: $qSymbol::6764625f6167656e745f74726163655f6275666665725f6c6f#0f...Packet received: qSymbol:6764625f6167656e745f74726163655f6275666665725f6869
> 00:00:47 Sending packet: $qSymbol::6764625f6167656e745f74726163655f6275666665725f6869#b7...Packet received: qSymbol:6764625f6167656e745f74726163656672616d655f726561645f636f756e74
> 00:00:47 Sending packet: $qSymbol::6764625f6167656e745f74726163656672616d655f726561645f636f756e74#b7...Packet received: qSymbol:6764625f6167656e745f74726163656672616d655f77726974655f636f756e74
> 00:00:47 Sending packet: $qSymbol::6764625f6167656e745f74726163656672616d655f77726974655f636f756e74#2e...Packet received: qSymbol:6764625f6167656e745f74726163656672616d65735f63726561746564
> 00:00:47 Sending packet: $qSymbol::6764625f6167656e745f74726163656672616d65735f63726561746564#4e...Packet received: qSymbol:6764625f6167656e745f74726163655f73746174655f7661726961626c6573
> 00:00:47 Sending packet: $qSymbol::6764625f6167656e745f74726163655f73746174655f7661726961626c6573#55...Packet received: qSymbol:6764625f6167656e745f6765745f7261775f726567
> 00:00:48 Sending packet: $qSymbol::6764625f6167656e745f6765745f7261775f726567#0d...Packet received: qSymbol:6764625f6167656e745f6765745f74726163655f73746174655f7661726961626c655f76616c7565
> 00:00:48 Sending packet: $qSymbol::6764625f6167656e745f6765745f74726163655f73746174655f7661726961626c655f76616c7565#a8...Packet received: qSymbol:6764625f6167656e745f7365745f74726163655f73746174655f7661726961626c655f76616c7565
> 00:00:48 Sending packet: $qSymbol::6764625f6167656e745f7365745f74726163655f73746174655f7661726961626c655f76616c7565#a5...Packet received: qSymbol:6764625f6167656e745f7573745f6c6f61646564
> 00:00:48 Sending packet: $qSymbol::6764625f6167656e745f7573745f6c6f61646564#cc...Packet received: qSymbol:6764625f6167656e745f68656c7065725f7468726561645f6964
> 00:00:48 Sending packet: $qSymbol::6764625f6167656e745f68656c7065725f7468726561645f6964#4f...Packet received: qSymbol:6764625f6167656e745f636d645f627566
> 00:00:48 Sending packet: $qSymbol::6764625f6167656e745f636d645f627566#5d...Packet received: qSymbol:6e70746c5f76657273696f6e
> 00:00:49 Sending packet: $qSymbol::6e70746c5f76657273696f6e#4d...Packet received: qSymbol:6e70746c5f76657273696f6e
> 00:00:49 Sending packet: $qSymbol::6e70746c5f76657273696f6e#4d...Packet received: qSymbol:6e70746c5f76657273696f6e
> 00:00:49 Sending packet: $qSymbol::6e70746c5f76657273696f6e#4d...Packet received: OK
>
> Since I have 10 shared libraries in that executable, this costs me about
> 1 minute delay, and is completely wasted, because I am not going to use
> tracepoints.
Most of that querying is actually unnecessary. All the symbols the
tracepoints module is looking up are required for libinproctrace.so to be
active. So, there's no need to look them all up if any fails to be found, since
if any fails, we know we don't have libinproctrace.so loaded yet. In practice,
we end up doing one (tracepoint related) query per DSO only. Can you give the
patch below a try? We have had this in our tree for months. Hopefuly it'll
still apply cleanly.
--
Pedro Alves
2011-01-27 Pedro Alves <pedro@codesourcery.com>
gdb/gdbserver
* gdbserver (tracepoint_look_up_symbols): Return upon the
first symbol error.
Index: gdb/gdbserver/tracepoint.c
===================================================================
--- gdb.orig/gdbserver/tracepoint.c 2011-01-26 15:52:39.634522000 -0200
+++ gdb/gdbserver/tracepoint.c 2011-01-26 16:14:59.554522000 -0200
@@ -320,13 +320,11 @@
void
tracepoint_look_up_symbols (void)
{
- int all_ok;
int i;
if (all_tracepoint_symbols_looked_up)
return;
- all_ok = 1;
for (i = 0; i < sizeof (symbol_list) / sizeof (symbol_list[0]); i++)
{
CORE_ADDR *addrp =
@@ -336,11 +334,11 @@
{
if (debug_threads)
fprintf (stderr, "symbol `%s' not found\n", symbol_list[i].name);
- all_ok = 0;
+ return;
}
}
- all_tracepoint_symbols_looked_up = all_ok;
+ all_tracepoint_symbols_looked_up = 1;
}
#endif
next prev parent reply other threads:[~2011-07-19 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 18:13 Paul Pluzhnikov
2011-07-19 18:44 ` Pedro Alves [this message]
2011-07-19 20:31 ` Paul Pluzhnikov
2011-07-20 12:34 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107191928.23553.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox