From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27545 invoked by alias); 19 Jul 2011 16:38:02 -0000 Received: (qmail 27404 invoked by uid 22791); 19 Jul 2011 16:38:01 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jul 2011 16:37:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6JGbVn2011946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jul 2011 12:37:31 -0400 Received: from host1.jankratochvil.net (ovpn-116-20.ams2.redhat.com [10.36.116.20]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6JGbUwL016597; Tue, 19 Jul 2011 12:37:31 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p6JGbT4S011381; Tue, 19 Jul 2011 18:37:29 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p6JGbS1l011374; Tue, 19 Jul 2011 18:37:28 +0200 Date: Tue, 19 Jul 2011 16:40:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch 00/12] entryval: Fix x86_64 parameters, virtual tail call frames Message-ID: <20110719163728.GA10909@host1.jankratochvil.net> References: <20110718201344.GA30496@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00476.txt.bz2 On Tue, 19 Jul 2011 18:26:03 +0200, Tom Tromey wrote: > In particular I think patches 1, 3, 8, 9, and 12 are ok without additional > comment. OK, thanks. > I noticed that you did not patch the DWARF->AX translator. If you'd > rather not do this, or if it isn't possible, that is fine; the > translator is already incomplete, simply because AX is not expressive > enough. It just "safely" says: DWARF operator DW_OP_GNU_entry_value cannot be translated to an agent expression I have seen more opcodes not implemented so I did not feel so guilty. It may have been discussed - it is not in `(gdb)Rationale' - why isn't AX at least derived from DWARF? But I guess the answer is the part of DWARF expressions compatible with `(gdb)Rationale' --- the AX requirements - is negligibly small. Thanks, Jan