Re: [commit] Re: [dwarf2_mark_helper patch] Re: [PATCH] Make interrupting tab-completion safe.

Tom Tromey
2011-07-12T21:18:36Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> After some discussion on IRC whether QUIT should or should not be
Jan> allowed for dwarf2read this patch should be OK and I have checked
Jan> it in:

To recap, based on existing code we believe it is not only safe to have
a QUIT in the full symbol reader, but we think more should probably be
added.

psymtab reading appears to remain unsafe, or at least unexplored.
However, allowing QUITs here would also be nice.

QUITs in symtab reading imply resource leaks; however there are already
known resource leaks in this code (Jan has details). My belief is that
we should move away from obstack allocation here and to something more
fine-grained like an alloc pool.

Tom