From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 680 invoked by alias); 4 Jul 2011 14:08:32 -0000 Received: (qmail 671 invoked by uid 22791); 4 Jul 2011 14:08:32 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SARE_SUB_IMPROVE X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 14:08:11 +0000 Date: Mon, 04 Jul 2011 14:10:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Improve performance with lots of shared libraries Message-ID: <20110704140808.GB2783@redhat.com> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20110701165109.GA3399@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00096.txt.bz2 Tom Tromey wrote: > >>>>> "Gary" == Gary Benson writes: > > Gary> While working on a new linker-debugger interface I took some > Gary> time out to do a bit of profiling to see exactly where gdb is > Gary> spending its time with inferiors that load a lot of shared > Gary> libraries, and it turned out that the top 30% of the profile > Gary> was update_section_map and the things it calls. > > Nice. > > I think this will solve a problem I had: > > http://sourceware.org/ml/gdb-patches/2011-03/msg00606.html Oh, I think it will. Nice! > I have a couple nits. > > Gary> +/* Nonzero if the location stopoed at is the shlib event breakpoint. */ > > Typo, "stopped". > > Gary> +static int > Gary> +at_solib_event_breakpoint (struct execution_control_state *ecs) > Gary> +{ > Gary> + struct solib_event_breakpoint_helper_arg arg; > Gary> + arg.prev_pc = ecs->event_thread->prev_pc; > > Blank line between declarations and code. Cool, fixed. Thanks, Gary -- http://gbenson.net/