From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17498 invoked by alias); 4 Jul 2011 13:14:28 -0000 Received: (qmail 17488 invoked by uid 22791); 4 Jul 2011 13:14:27 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.uk.ibm.com (HELO mtagate6.uk.ibm.com) (194.196.100.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 13:14:02 +0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p64DDxZ1014882 for ; Mon, 4 Jul 2011 13:13:59 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p64DDxQH1998906 for ; Mon, 4 Jul 2011 14:13:59 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p64DDwSe029322 for ; Mon, 4 Jul 2011 07:13:59 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p64DDvoS029301; Mon, 4 Jul 2011 07:13:57 -0600 Message-Id: <201107041313.p64DDvoS029301@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 04 Jul 2011 15:13:57 +0200 Subject: Re: [commit] Re: [patch 1/2] physname reg.: linespec minsym fallback To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Mon, 04 Jul 2011 14:08:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20110701202105.GA22980@host1.jankratochvil.net> from "Jan Kratochvil" at Jul 01, 2011 10:21:05 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00095.txt.bz2 Jan Kratochvil wrote: > 2011-07-01 Jan Kratochvil > > + Fall back linespec to minimal symbols. > + * linespec.c (decode_line_1): New variable ex, saved_argptr. Protect > + decode_compound by TRY_CATCH, fall back on minsyms if it failed. > + (find_method, symbol_found): Change error to cplusplus_error. On some machines (RHEL 5.6 with GCC 4.1.2 system compiler) I'm now seeing: cc1: warnings being treated as errors /home/kwerner/dailybuild/spu-tc-2011-07-04/gdb-head/src/gdb/linespec.c: In function 'decode_line_1': /home/kwerner/dailybuild/spu-tc-2011-07-04/gdb-head/src/gdb/linespec.c:928: warning: 'values.nelts' may be used uninitialized in this function /home/kwerner/dailybuild/spu-tc-2011-07-04/gdb-head/src/gdb/linespec.c:928: warning: 'values.sals' may be used uninitialized in this function Should there be an initializer somewhere? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com