From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2904 invoked by alias); 1 Jul 2011 15:16:39 -0000 Received: (qmail 2875 invoked by uid 22791); 1 Jul 2011 15:16:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jul 2011 15:16:24 +0000 Received: (qmail 9254 invoked from network); 1 Jul 2011 15:16:23 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Jul 2011 15:16:23 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH/RFC] gdb: tests: add support for testing FLAT toolchains Date: Fri, 01 Jul 2011 15:16:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Mike Frysinger , toolchain-devel@blackfin.uclinux.org References: <201003182126.17119.vapier@gentoo.org> <201107011016.57120.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201107011616.21075.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00019.txt.bz2 On Friday 01 July 2011 15:28:17, Mike Frysinger wrote: > On Fri, Jul 1, 2011 at 05:16, Pedro Alves wrote: > > On Friday 01 July 2011 01:24:41, Mike Frysinger wrote: > >> From: Jie Zhang > >> > >> FLAT toolchains output a FLAT binary for the named output and create > >> another file with a .gdb suffix that is used for debugging. So when > >> testing a FLAT toolchain and we need to load up a file, use the .gdb. > > > > Sounds a lot like the recently added > > lib/gdb.exp:exec_target_file/exec_symbol_file hooks? We added them > > to solve the exact same problem. We then have this in our board file > > for uclinux/flat toolchains: > > > > proc exec_target_file { binfile } { > > return ${binfile}.flt > > } > > probably ... this code does date back years ago, and when i poked > things again one year ago, it still needed to be done. i'll take a > look at what you refer to now though. I took another look at how we do things. Those hooks I pointed at are only part of the story, and are not enough for what you need --- we _also_ override gdb_compile in our board files, calling the existing version, and then doing the renaming very similarly to what your patch does. (What I've wondered before was if it was possible to pass enough switches to the tools in order to have them output the files with the names we need in the first place, in order to avoid the renaming.) I'm not super keen on having these target and environment pecularities straight in the core testsuite code. I'd rather we had enough hooks to make it easy for a board file or a config file to do what it needs to. E.g., symbian toolchains also have separate binary and symbol files (the reason shlib_target_file/shlib_symbol_file were added a while ago, uppon which exec_target_file/exec_symbol_file were later modelled on), and the extension is not .flt then, of course. Maybe we could do something like gdb/testsuite/config/gdbserver.exp/gdb/testsuite/lib/gdbserver-support.exp instead? That is, move your code to new gdb/testsuite/config/flt.exp gdb/testsuite/lib/flt-support.exp files that do what you have, but by overriding what needs overriding (gdb_compile and the exec_*_file hooks mainly)? WDYT? -- Pedro Alves