Re: [patch 2/2] Disable epilogue unwinders on recent GCCs [Re: Regression: Re: [PATCH] Fix some i386 unwinder inconcistencies]

Tom Tromey
2011-06-28T20:02:16Z

>>>>> "Mark" == Mark Kettenis <mark.kettenis@xs4all.nl> writes:

>> 1441 /* This restriction could be lifted if other unwinders are known to
>> 1442 compute the frame base in a way compatible with the DWARF
>> 1443 unwinder. */
>> 1444 if (! frame_unwinder_is (this_frame, &dwarf2_frame_unwind))
>> 1445 error (_("can't compute CFA for this frame"));

Mark> I still think, this code should be removed. Tom, since you added that
Mark> bit, what's your take on that?

When I wrote that I was under the impression that the different
unwinders computed the CFA differently.

If that is incorrect, and recent discussion indicates that it is, then I
think it is fine to drop this check.

Actually, the whole purpose of frame_unwinder_is and dwarf2_frame_cfa is
just to do this check. All that stuff could be removed.

Tom