From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23859 invoked by alias); 28 Jun 2011 15:51:32 -0000 Received: (qmail 23850 invoked by uid 22791); 28 Jun 2011 15:51:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jun 2011 15:51:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2F95C2BB2AC; Tue, 28 Jun 2011 11:51:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id K7-fxY1KHYxw; Tue, 28 Jun 2011 11:51:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D94472BB29B; Tue, 28 Jun 2011 11:51:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8C635145615; Tue, 28 Jun 2011 08:51:07 -0700 (PDT) Date: Tue, 28 Jun 2011 15:51:00 -0000 From: Joel Brobecker To: Marek Polacek Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649) Message-ID: <20110628155107.GL20676@adacore.com> References: <4E09E2C1.2020909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E09E2C1.2020909@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00417.txt.bz2 > 2011-06-28 Marek Polacek > > * gdb.python/py-evthreads.exp: Fix race by adding an anchor to match > the whole output. This is an area where I'm not entirely sure, but we usually use `$gdb_prompt $' as the anchor. I'm also surprised to see some uses of gdb_expect in gdb.python. I wonder if we could replace them with uses of gdb_test_multiple (that would be a separate patch)... -- Joel