From: Eric Botcazou <ebotcazou@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [patch] Add support for single register window model on SPARC
Date: Mon, 27 Jun 2011 14:11:00 -0000 [thread overview]
Message-ID: <201106271610.26710.ebotcazou@adacore.com> (raw)
In-Reply-To: <201106231314.p5NDE37t015068@glazunov.sibelius.xs4all.nl>
> Typically, yes, but because of:
>
> /* FIXME: kettenis/20050423: Don't enable the unwinder until the
> StackGhost issues have been resolved. */
>
> we only install the DWARF unwinder for Linux, and I guess you tested
> on some other platform.
Yes, on Solaris. I'll give it a whirl on Linux to see how the DWARF unwinder
fares then.
> No regression on OpenBSD/sparc64, so all fine with me.
Thanks for the review.
Joel, I have commit rights to src but I'm not listed in MAINTAINERS so would
you mind applying the revised patch (gdb-mflat-2.diff) attached to my previous
message in the thread? TIA.
2011-06-27 Eric Botcazou <ebotcazou@adacore.com>
* sparc-tdep.h (struct sparc_frame_cache): Add frame_offset,
saved_regs_mask and copied_regs_mask fields.
(sparc_record_save_insn): New prototype.
* sparc-tdep.c (sparc_alloc_frame_cache): Initialize the new fields.
(sparc_record_save_insn): New function.
(sparc_analyze_prologue): Add head comment. Recognize store insns
of call-saved registers. Use OFFSET consistently. Recognize flat
frames and cache their settings.
(sparc32_skip_prologue): Handle flat frames.
(sparc_frame_cache): Add frame_offset to the base address.
(sparc32_frame_cache): Adjust to new frame description.
(sparc32_frame_prev_register): Likewise.
* sparc64-tdep.c (sparc64_frame_prev_register): Likewise.
* sparc-sol2-tdep.c (sparc32_sol2_sigtramp_frame_cache): Likewise.
* sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_cache): Likewise.
* sparcnbsd-tdep.c (sparc32nbsd_sigcontext_frame_cache): Force the
frame by calling sparc_record_save_insn.
* sparc64nbsd-tdep.c (sparc64nbsd_sigcontext_frame_cache): Likewise.
* sparcobsd-tdep.c (sparc32obsd_sigtramp_frame_cache): Likewise.
* sparc64obsd-tdep.c (sparc64obsd_frame_cache): Likewise.
--
Eric Botcazou
next prev parent reply other threads:[~2011-06-27 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 13:37 Eric Botcazou
2011-06-21 12:12 ` Mark Kettenis
2011-06-21 18:08 ` Eric Botcazou
2011-06-23 13:14 ` Mark Kettenis
2011-06-27 14:11 ` Eric Botcazou [this message]
2011-06-27 16:41 ` Joel Brobecker
2011-06-27 17:01 ` Eric Botcazou
2011-06-28 20:12 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106271610.26710.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox