From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 428 invoked by alias); 27 Jun 2011 15:54:48 -0000 Received: (qmail 420 invoked by uid 22791); 27 Jun 2011 15:54:47 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Jun 2011 15:54:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 945662BB226; Mon, 27 Jun 2011 11:54:30 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xrcjd28BZxKd; Mon, 27 Jun 2011 11:54:30 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6E5A62BB221; Mon, 27 Jun 2011 11:54:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5463B145615; Mon, 27 Jun 2011 08:54:25 -0700 (PDT) Date: Mon, 27 Jun 2011 15:54:00 -0000 From: Joel Brobecker To: Liang Cheng Cc: gdb-patches@sourceware.org Subject: Re: [patch] failed to attach to the same process after detaching in gdbserver multiprocess mode Message-ID: <20110627155425.GE20676@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00396.txt.bz2 Liang, Thanks for sending these patches in. I can't really approve your patches since I don't have expertise in that area, but I can comment on a couple of things: - It's great that you take the time to explain what the problem is; - Patches should have a ChangeLog entry to accompany them; - One nit: It's awesome that you take the time to add comments to document the code, and we don't use them often enough IMO. But I think that, in general, we want the comments in the code to say *why* you do what you do. And oh, comments should start with a capital letter, and end with a period (and we always put 2 spaces after period, even before a closing */ > + > + /* reset cont_thread */ > + cont_thread = null_ptid; > return 0; -- Joel