From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20078 invoked by alias); 22 Jun 2011 20:49:20 -0000 Received: (qmail 20070 invoked by uid 22791); 22 Jun 2011 20:49:19 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jun 2011 20:48:56 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 300F41B4018; Wed, 22 Jun 2011 20:48:56 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: start a unified sim_do_command Date: Wed, 22 Jun 2011 20:49:00 -0000 User-Agent: KMail/1.13.7 (Linux/2.6.39; KDE/4.6.3; x86_64; ; ) Cc: Tom Tromey , toolchain-devel@blackfin.uclinux.org References: <1308516139-32225-1-git-send-email-vapier__28363.8018918738$1308516131$gmane$org@gentoo.org> <201106221616.01999.vapier@gentoo.org> In-Reply-To: <201106221616.01999.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2458503.td95Vt3udC"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201106221648.56445.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00331.txt.bz2 --nextPart2458503.td95Vt3udC Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1824 On Wednesday, June 22, 2011 16:16:00 Mike Frysinger wrote: > On Wednesday, June 22, 2011 16:01:10 Tom Tromey wrote: > > >>>>> "Mike" =3D=3D Mike Frysinger writes: > > Mike> Since sim_do_command for many people simply calls sim_args_comman= d, > > start Mike> a unified version of it. For people who handle their own > > options, they Mike> could switch to this by using sim_add_option_table > > instead. > >=20 > > I don't actually know anything about this code, but the patch seems to > > remove implementations of sim_do_command that do more than dispatch to > > sim_args_command. >=20 > some arches didnt call sim_args_command(), now they do. bug fix for them. >=20 > some arches would display an error message when users passed an old comma= nd > option and inform them of the new one. i think people have had long enou= gh > for that migration, and they can pretty easily figure things out with the > normal help output. >=20 > m68hc11 provided a dedicated "info" to call an arch-specific > sim_get_info(), but the common sim_info() entry point also calls that.=20 > m68hc11 would also rewrite its internal device tree when people changed > files, but this behavior deviates from the standard sim behavior, so i > dont think it should be there at all. the normal sim workflow > (target;file;load) should continue to work. >=20 > m32r provided a dedicated hook for reading two pseudo registers, but that > should be done via the normal gdb interface rather than hooking the comma= nd > line like this. >=20 > i think that sums up all deviations. if the m68hc11/m32r peeps really want to keep this behavior, i can rework t= he=20 Makefiles so that arches have to opt into the command. the idea though was= to=20 make this a standard func so that new ports would get it automatically too. -mike --nextPart2458503.td95Vt3udC Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOAlU4AAoJEEFjO5/oN/WBf0wQAKPwRDXYait0D3hW3dg4KOTF ioHeJoEH3kxODb4Zhjo1KtEA6zRI1Do88kKD+zV4P4I+XXtOg7Ez3cF/YT6v+WCp fRomvChfRixC/sW/l5fvmGbCt3xpzccIA4sKdyDNa1jAhZ0zYG+jXVAV03+kwZVz MQf/C2kkVcWMN25HkA0RtkVpBM9eAeETs33k9U443WJIR9HSDOpFISi3FDNv49ad 5wzT8P4Ld1/NO5apI8FtuE6yn/H4oflp7yzLJlqN9tp/Yp0POa5ULzVampJwmgaK 4XxtzUDYuE43l+yf130zDEnAMzKXW2Ew5KOGoL1mzxjXUzyXa9XPVoOY5dHdiFY1 jtfp0Bp7O/6NK2g+584GeVchZJkkYryYiuoJHqJC7ohBdO2aR7knBGBgCS7BICyb pDNSWRegz6waHo9Wm6PIDW9XkCyA0xDMbVGIo5fve8t4fFAYGMW26gI7RYj3lpnM MLGprlZXoi7dAlxkbyoNhw54FZHARDp1g9qG9u9rGpRNBrrPOC5AnBQ9Nmo8iMEM xoUKjOz7eBuciADGLNNO5N4opX4PrE15d5lfxfmVFa27VxxWfqZSqifX5HTkn1SY O23PAQvXZlOh7i3Sre6sn4F5iDwQHshq1hxftzC8XAQO18K2xjDIO2wCvPFjNyvl jYluu8w1MdmRsvNk9asT =XHNY -----END PGP SIGNATURE----- --nextPart2458503.td95Vt3udC--