From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13086 invoked by alias); 22 Jun 2011 20:16:19 -0000 Received: (qmail 13074 invoked by uid 22791); 22 Jun 2011 20:16:17 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jun 2011 20:16:02 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 2520F2AC017; Wed, 22 Jun 2011 20:16:02 +0000 (UTC) From: Mike Frysinger To: Tom Tromey Subject: Re: [PATCH] sim: start a unified sim_do_command Date: Wed, 22 Jun 2011 20:16:00 -0000 User-Agent: KMail/1.13.7 (Linux/2.6.39; KDE/4.6.3; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1308516139-32225-1-git-send-email-vapier__28363.8018918738$1308516131$gmane$org@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4180263.E5BK24q0Sz"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201106221616.01999.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00330.txt.bz2 --nextPart4180263.E5BK24q0Sz Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1482 On Wednesday, June 22, 2011 16:01:10 Tom Tromey wrote: > >>>>> "Mike" =3D=3D Mike Frysinger writes: > Mike> Since sim_do_command for many people simply calls sim_args_command, > start Mike> a unified version of it. For people who handle their own > options, they Mike> could switch to this by using sim_add_option_table > instead. >=20 > I don't actually know anything about this code, but the patch seems to > remove implementations of sim_do_command that do more than dispatch to > sim_args_command. some arches didnt call sim_args_command(), now they do. bug fix for them. some arches would display an error message when users passed an old command= =20 option and inform them of the new one. i think people have had long enough= =20 for that migration, and they can pretty easily figure things out with the=20 normal help output. m68hc11 provided a dedicated "info" to call an arch-specific sim_get_info()= ,=20 but the common sim_info() entry point also calls that. m68hc11 would also= =20 rewrite its internal device tree when people changed files, but this behavi= or=20 deviates from the standard sim behavior, so i dont think it should be there= at=20 all. the normal sim workflow (target;file;load) should continue to work. m32r provided a dedicated hook for reading two pseudo registers, but that=20 should be done via the normal gdb interface rather than hooking the command= =20 line like this. i think that sums up all deviations. -mike --nextPart4180263.E5BK24q0Sz Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOAk2BAAoJEEFjO5/oN/WBT7gP/3UayrwBJIufN9zvRcDp2m8o Mng+lgJ28OesMb1iWF4pdfVCU7JlXQRhTdOfSGc+qhfwXopEY+bmWYjN+goAWeNc VAPKI/Pu3aCHfdpPppMorCFEdtjQ499qvhar+PQShg+McUrK4YohfvRnKMy9fC+d 0QvWIzPvABhyn20kD4LV0kSmqbE9vMkYOXRzukDFeXgs9iH5cbHFTyLe9xu/lFWy H1eQY3PH1DFipQD8IGE6kneCHJ5RDhmgNX/FSdQnRSC4TCfTuuEN7Vd6sTtM7JMQ 7WRSV7p+FvRE7g6hX2xIeCdtqH2pelPgzGJ0y8qWkougef61PWuCnEZBoo9wm6NY Uq6xdL1KzzCGkFJTp9Kg60BkJfoddUFcEHhdqdgmxFGoJoWNqqYv0HkLZvuxnj/x Ad54sU15sNcMz5giwSYZSPNLDQQ5fUKIfjxBq+IlH4bpCvW2lFyRCe2KkFrHdcKv 0jyx+hfHFOWM50dgZHNH2j5lUyFR3VRObxvlycGU/0Fq6Ax6hcZ6sXqIQ6GnDCld nM7HpbnAarKsB1LlTyhnFMQI08xNK3C/eeARKexy989xC0K38Ytjca1qHnutWkrd U/jsIDrETy9afY3cZ474e+KsudTywrSIYEEuf4Uw1ko86Jape3M/f85Z7u753g6k 1B5iu6RDKMGoG/jdj3iV =elSv -----END PGP SIGNATURE----- --nextPart4180263.E5BK24q0Sz--