From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28594 invoked by alias); 21 Jun 2011 09:18:11 -0000 Received: (qmail 28574 invoked by uid 22791); 21 Jun 2011 09:18:10 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Jun 2011 09:17:48 +0000 Received: (qmail 23423 invoked from network); 21 Jun 2011 09:17:47 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Jun 2011 09:17:47 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Remove write-only local variable sw_single_step_trap_p Date: Tue, 21 Jun 2011 09:18:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Yao Qi References: <4E002E7F.80903@codesourcery.com> In-Reply-To: <4E002E7F.80903@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201106211017.43440.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00277.txt.bz2 On Tuesday 21 June 2011 06:39:11, Yao Qi wrote: > Local variable sw_single_step_trap_p is not read in > handle_inferior_event. We can safely remove it. > > It is somewhat obvious, and I'll check it in in 24 hours if no objection. This is okay. AFAICS, that variable became unused/unnecessary when gdb was made to adjust the PC early with adjust_pc_after_break. (I looked at 5.3's sources [circa 2002], to check how the variable was used back then) -- Pedro Alves