Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: amodra@gmail.com (Alan Modra)
Cc: gdb-patches@sourceware.org, binutils@sourceware.org,
	patches@linaro.org,        dave.martin@linaro.org,
	will.deacon@arm.com
Subject: Re: [rfc/rfa] VFP/NEON register set support for ARM core files
Date: Wed, 15 Jun 2011 16:44:00 -0000	[thread overview]
Message-ID: <201106151644.p5FGiHYb018103@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20110406030027.GL19002@bubble.grove.modra.org> from "Alan Modra" at Apr 06, 2011 12:30:27 PM

Alan Modra wrote:
> On Tue, Apr 05, 2011 at 08:50:14PM +0200, Ulrich Weigand wrote:
> > 	* elf-bfd.h (elfcore_write_arm_vfp): Add prototype.
> > 	* elf.c (elfcore_grok_arm_vfp): New function.
> > 	(elfcore_grok_note): Call it to handle NT_ARM_VFP notes.
> > 	(elfcore_write_arm_vfp): New function.
> > 	(elfcore_write_register_note): Call it to handle .reg-arm-vfp.
> 
> Looks OK to me.

The kernel parts have now been accepted (and will be available
with 3.0), so I've committed the binutils and gbd parts as well.

Note that I had originally forgotten to update readelf to properly
display the new note type; the version I've committed includes
this part as well (see additional patch below).

Thanks,
Ulrich


ChangeLog:

binutils/
	* readelf.c (get_note_type): Handle NT_ARM_VFP.


Index: binutils/readelf.c
===================================================================
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.547
diff -u -p -r1.547 readelf.c
--- binutils/readelf.c	13 Jun 2011 15:18:53 -0000	1.547
+++ binutils/readelf.c	15 Jun 2011 15:00:37 -0000
@@ -12284,6 +12284,8 @@ get_note_type (unsigned e_type)
 	return _("NT_S390_CTRS (s390 control registers)");
       case NT_S390_PREFIX:
 	return _("NT_S390_PREFIX (s390 prefix register)");
+      case NT_ARM_VFP:
+	return _("NT_ARM_VFP (arm VFP registers)");
       case NT_PSTATUS:
 	return _("NT_PSTATUS (pstatus structure)");
       case NT_FPREGS:


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


      reply	other threads:[~2011-06-15 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 18:50 Ulrich Weigand
2011-04-06  3:00 ` Alan Modra
2011-06-15 16:44   ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106151644.p5FGiHYb018103@d06av02.portsmouth.uk.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=dave.martin@linaro.org \
    --cc=gdb-patches@sourceware.org \
    --cc=patches@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox