From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23063 invoked by alias); 15 Jun 2011 10:27:32 -0000 Received: (qmail 23055 invoked by uid 22791); 15 Jun 2011 10:27:32 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jun 2011 10:27:18 +0000 Received: (qmail 3718 invoked from network); 15 Jun 2011 10:27:16 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Jun 2011 10:27:16 -0000 From: Pedro Alves To: Hui Zhu Subject: Re: [RFA] tracepoint remote.c:remote_trace_set_readonly_regions give up some regions if it is number is too big Date: Wed, 15 Jun 2011 10:27:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201106131321.33532.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106151127.12684.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00209.txt.bz2 On Wednesday 15 June 2011 08:33:46, Hui Zhu wrote: > On Mon, Jun 13, 2011 at 20:21, Pedro Alves wrote: > > Note that if your stub supports qXfer:traceframe-info:read, this packet > > is no longer necessary to support, as GDB will handle reading from > > readonly sections out of live memory itself. I think this > > means that the warning should only be output > > if remote_protocol_packets[PACKET_qXfer_traceframe_info].support > > is not PACKET_ENABLE? > > GDB can do that with itself? That is really cool. > All this function is implemented inside remote.c? No, it's in: target.c:memory_xfer_partial target.c:traceframe_available_memory target.c:memory_xfer_live_readonly_partial > What I suggest is if not need, don't send the QTro. Could work too. It would still be the same remote_protocol_packets[PACKET_qXfer_traceframe_info].support check... > And I suggest we always enable this check inside the function. That was never in question. I was only talking about silencing the _warning_. > 2011-06-15 Hui Zhu > > * remote.c (remote_trace_set_readonly_regions): Add a check for > target_buf_size. Okay. -- Pedro Alves