From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29623 invoked by alias); 13 Jun 2011 10:49:31 -0000 Received: (qmail 29614 invoked by uid 22791); 13 Jun 2011 10:49:31 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Jun 2011 10:49:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5DAnFIL022216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Jun 2011 06:49:15 -0400 Received: from host1.jankratochvil.net (ovpn-113-23.phx2.redhat.com [10.3.113.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5DAnDNA009970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 13 Jun 2011 06:49:14 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p5DAnCxJ003005; Mon, 13 Jun 2011 12:49:12 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p5DAnBmR002999; Mon, 13 Jun 2011 12:49:11 +0200 Date: Mon, 13 Jun 2011 10:49:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Regression: Re: [PATCH] Fix some i386 unwinder inconcistencies Message-ID: <20110613104911.GA1965@host1.jankratochvil.net> References: <201106122057.p5CKvUEa030437@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201106122057.p5CKvUEa030437@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00155.txt.bz2 On Sun, 12 Jun 2011 22:57:30 +0200, Mark Kettenis wrote: > This diff fixes a few issues with the epilogue and stack tramp unwinders. > > Committed. > > 2011-06-12 Mark Kettenis > > * i386-tdep.c (i386_epilogue_frame_cache): Simplify code. Call > get_frame_func instead of get_frame_pc to determine the code > address used to construct the frame ID. > (i386_epilogue_frame_unwind_stop_reason): Fix coding style. > (i386_epilogue_frame_this_id): Likewise. > (i386_epilogue_frame_prev_register): New function. > (i386_epilogue_frame_unwind): Use i386_epilogue_frame_prev_register. > (i386_stack_tramp_frame_sniffer): Fix coding style. > (i386_stack_tramp_frame_unwind): Use i386_epilogue_frame_prev_register. > (i386_gdbarch_init): Fix comments. On all the tested platforms Fedora-{13,14,15,Rawhide} for {i686,x86_64-m32} (but not for x86_64): -PASS: gdb.base/watchpoint-cond-gone.exp: Catch the no longer valid watchpoint +FAIL: gdb.base/watchpoint-cond-gone.exp: Catch the no longer valid watchpoint -XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (stopped at wrong place) +XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (unknown output after running) -XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (stopped at wrong place) +XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (unknown output after running) due to: commit b304e1f3bb4fee38d829dbd85ea3c0f43399aa7c This is a regression. The regressions are all just instances of: finish Run till exit from #0 func () at ./gdb.base/watchpoint-cond-gone.c:26 - -Watchpoint 3 deleted because the program has left the block in -which its expression is valid. +Error evaluating expression for watchpoint 3 +can't compute CFA for this frame +Watchpoint 3 deleted. 0x080483e0 in func () at ./gdb.base/watchpoint-cond-gone.c:28 28 } -(gdb) PASS: gdb.base/watchpoint-cond-gone.exp: Catch the no longer valid watchpoint +(gdb) FAIL: gdb.base/watchpoint-cond-gone.exp: Catch the no longer valid watchpoint Thanks, Jan