From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32552 invoked by alias); 10 Jun 2011 22:00:49 -0000 Received: (qmail 32543 invoked by uid 22791); 10 Jun 2011 22:00:48 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,FAKE_REPLY_C,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 22:00:35 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5AM0MuU025380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Jun 2011 18:00:22 -0400 Received: from host1.jankratochvil.net (ovpn-113-23.phx2.redhat.com [10.3.113.23]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5AM05gj015376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Jun 2011 18:00:18 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p5AM05TO030090; Sat, 11 Jun 2011 00:00:05 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p5AM05Zd030089; Sat, 11 Jun 2011 00:00:05 +0200 Date: Fri, 10 Jun 2011 22:00:00 -0000 From: Jan Kratochvil To: Tom Tromey , Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/2, 7.3] Fix 7.1->7.2 regression: info sources Message-ID: <20110610220005.GB29212@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110610212635.GI12834@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00146.txt.bz2 On Fri, 10 Jun 2011 23:26:35 +0200, Joel Brobecker wrote: > > +gdb_test "info sources" {/file1\.txt} > > I don't think this is going to work on MinGW. But do we support > running the testsuite on MinGW? I do not know but maybe the testsuite do not have so many pathname delimiters expectations; changed it. On Fri, 10 Jun 2011 22:56:09 +0200, Tom Tromey wrote: > I agree. On Fri, 10 Jun 2011 23:26:35 +0200, Joel Brobecker wrote: > Agreed as well. Checked in, HEAD: http://sourceware.org/ml/gdb-cvs/2011-06/msg00056.html and 7.3: http://sourceware.org/ml/gdb-cvs/2011-06/msg00057.html Thanks, Jan http://sourceware.org/ml/gdb-cvs/2011-06/msg00056.html --- src/gdb/ChangeLog 2011/06/10 21:48:03 1.13087 +++ src/gdb/ChangeLog 2011/06/10 21:50:53 1.13088 @@ -1,5 +1,10 @@ 2011-06-10 Jan Kratochvil + * symtab.c (output_partial_symbol_filename): Exchange the filename and + fullname parameters order. + +2011-06-10 Jan Kratochvil + Code cleanup. * dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype for fun. --- src/gdb/testsuite/ChangeLog 2011/06/10 16:21:46 1.2742 +++ src/gdb/testsuite/ChangeLog 2011/06/10 21:50:55 1.2743 @@ -1,3 +1,7 @@ +2011-06-10 Jan Kratochvil + + * gdb.dwarf2/dw2-filename.exp (info sources): New testcase. + 2011-06-10 Tom Tromey * gdb.cp/temargs.exp: Let tests pass if compiler bug is fixed. --- src/gdb/symtab.c 2011/05/18 16:30:36 1.274 +++ src/gdb/symtab.c 2011/06/10 21:50:54 1.275 @@ -2837,7 +2837,7 @@ /* A callback for map_partial_symbol_filenames. */ static void -output_partial_symbol_filename (const char *fullname, const char *filename, +output_partial_symbol_filename (const char *filename, const char *fullname, void *data) { output_source_filename (fullname ? fullname : filename, data); --- src/gdb/testsuite/gdb.dwarf2/dw2-filename.exp 2011/01/19 20:26:09 1.3 +++ src/gdb/testsuite/gdb.dwarf2/dw2-filename.exp 2011/06/10 21:50:55 1.4 @@ -38,3 +38,6 @@ # is that the file and fullname fields are now inverted. gdb_test "interpreter-exec mi -file-list-exec-source-files" \ ".*{file=\"file1\\.txt\",fullname=\".+file1\\.txt\"}.*" + +# And `info sources' should return the fullname incl. the directories. +gdb_test "info sources" {[/\\]file1\.txt}