From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30242 invoked by alias); 10 Jun 2011 20:33:42 -0000 Received: (qmail 30234 invoked by uid 22791); 10 Jun 2011 20:33:41 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 20:33:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5AKX4tk022409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Jun 2011 16:33:04 -0400 Received: from host1.jankratochvil.net (ovpn-113-23.phx2.redhat.com [10.3.113.23]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5AKX2sG017892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Jun 2011 16:33:03 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p5AKX17j001176; Fri, 10 Jun 2011 22:33:01 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p5AKX1dZ001158; Fri, 10 Jun 2011 22:33:01 +0200 Date: Fri, 10 Jun 2011 20:33:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Joel Brobecker Subject: [patch 2/2, 7.3] Fix 7.1->7.2 regression: info sources Message-ID: <20110610203300.GB31746@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00140.txt.bz2 Hi, https://bugzilla.redhat.com/show_bug.cgi?id=712117 724d4482b9db1aced5ae391ad624f76877991232 is the first bad commit [PATCH] Fix regression in -file-list-exec-source-files command. http://sourceware.org/ml/gdb-patches/2010-08/msg00333.html http://sourceware.org/ml/gdb-patches/2010-09/msg00090.html `info sources' no longer displays the pathname. Fix it. Source files for which symbols will be read in on demand: file1.txt (gdb) FAIL: gdb.dwarf2/dw2-filename.exp: info sources -> Source files for which symbols will be read in on demand: /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.dwarf2/file1.txt (gdb) PASS: gdb.dwarf2/dw2-filename.exp: info sources No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu. I believe it should go for 7.3, I will check it in there. Thanks, Jan gdb/ 2011-06-10 Jan Kratochvil * symtab.c (output_partial_symbol_filename): Exchange the filename and fullname parameters order. gdb/testsuite/ 2011-06-10 Jan Kratochvil * gdb.dwarf2/dw2-filename.exp (info sources): New testcase. --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -2837,7 +2837,7 @@ output_source_filename (const char *name, int *first) /* A callback for map_partial_symbol_filenames. */ static void -output_partial_symbol_filename (const char *fullname, const char *filename, +output_partial_symbol_filename (const char *filename, const char *fullname, void *data) { output_source_filename (fullname ? fullname : filename, data); --- a/gdb/testsuite/gdb.dwarf2/dw2-filename.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp @@ -38,3 +38,6 @@ clean_restart ${testfile}.x # is that the file and fullname fields are now inverted. gdb_test "interpreter-exec mi -file-list-exec-source-files" \ ".*{file=\"file1\\.txt\",fullname=\".+file1\\.txt\"}.*" + +# And `info sources' should return the fullname incl. the directories. +gdb_test "info sources" {/file1\.txt}