From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26000 invoked by alias); 7 Jun 2011 22:57:10 -0000 Received: (qmail 25991 invoked by uid 22791); 7 Jun 2011 22:57:09 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jun 2011 22:56:55 +0000 Received: (qmail 8946 invoked from network); 7 Jun 2011 22:56:54 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Jun 2011 22:56:54 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Fix `shell' command for async (PR 12850) Date: Tue, 07 Jun 2011 22:57:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Joel Brobecker , Ulrich.Weigand@de.ibm.com References: <20110607152409.GA7600@host1.jankratochvil.net> <201106071813.24470.pedro@codesourcery.com> <20110607190559.GB12834@adacore.com> In-Reply-To: <20110607190559.GB12834@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106072356.51967.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00106.txt.bz2 On Tuesday 07 June 2011 20:05:59, Joel Brobecker wrote: > > > +++ b/gdb/rs6000-nat.c > > > @@ -614,7 +614,7 @@ exec_one_dummy_insn (struct regcache *regcache) > > > > (Urgh, had never seen this bizarre code before. I wonder if > > this is still needed on any sane platform, or if it was only > > necessary on some ancient aix.) > > I think it's worth testing. That'd be great. It'd get rid of another instance of deprecated_insert_raw_breakpoint along with the bizarreness. :-) > From the logs that I could gather, > this function was already there in 1992 (!) but it's not entirely > clear that it was for AIX. But, right now, I'd have a hard time > believing that it would be for any other kernel but AIX (the other > ones I can see are (Linux, *BSDs). It can only be for AIX, AFAICS. grepping for rs6000-nat.o only hits on gdb/config/powerpc/aix.mh --- the whole rs6000-nat.c file is AIX only. > The oldest AIX we have now at AdaCore is 5.2. I'm wondering if Ulrich > might have access to something a little older? -- Pedro Alves