From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1481 invoked by alias); 3 Jun 2011 18:34:10 -0000 Received: (qmail 1340 invoked by uid 22791); 3 Jun 2011 18:34:08 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_RG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Jun 2011 18:33:52 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id E14501B402E; Fri, 3 Jun 2011 18:33:51 +0000 (UTC) From: Mike Frysinger To: Tom Tromey Subject: Re: [PATCH/RFC] new argv handlers to help with sim argv building Date: Fri, 03 Jun 2011 18:34:00 -0000 User-Agent: KMail/1.13.7 (Linux/2.6.39; KDE/4.6.3; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org> <201106011217.55915.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5896559.cj8Jt5EhYd"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201106031302.56937.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00059.txt.bz2 --nextPart5896559.cj8Jt5EhYd Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1025 On Friday, June 03, 2011 12:56:24 Tom Tromey wrote: > >>>>> "Mike" =3D=3D Mike Frysinger writes: > Mike> +char **appendargv (char **argv, const char *arg, ...) >=20 > Wrong formatting. i dont know what you mean > The canonical source for libiberty is gcc, so changes have to go there. yes, but i'm just bouncing the idea right now > Mike> + argv =3D appendargv (argv, "--sysroot", gdb_sysroot, NULL); > [...] > Mike> + uargv =3D gdb_buildargv (args); > Mike> + sim_argv =3D mergeargv (argv, uargv, NULL); > Mike> + freeargv (argv); >=20 > If there is only one argument potentially needing quoting from > buildargv, and we have to do splitting and merging as well, then it > seems like it would be simpler to just add a quoting function and use > that. quoting opens a whole can of worms i dont want to think about. simply=20 sticking quotes around gdb_sysroot doesnt solve the whole problem. what if= =20 the sysroot has quotes in it ? i'd prefer to stick in the argv world. -mike --nextPart5896559.cj8Jt5EhYd Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJN6RPAAAoJEEFjO5/oN/WBEaUQAI3FyGp1iangYAUugGoj2WHp Fwu39OU7TyP0v/VySIcayieLcKC+E9tiCBnBQHMtbOkP3mcRd7JR6okGcDaVasl0 WfOEGMl3aygZxfU+fZWU99HJF2eNyiZ8W06m67OmI/SFbJlHFGF1tW9S7srr+hgm vzehZ5X89Yp5oclURVTHiDC+vSM2k9ka4l2GlxbO8x42c9VDLEs+icRgEgZUhy5X 38kN5okgf2kQkm1gp9yFOXTznsK4sRH4Sz9rg96ZT60NWT2b2LaUkYqqcVF6F+CK OKV8XrtcWBdU3HD4kmbZrrZNI49CEWbiP6iu1UExvT/S+P1pSsYovRGEUaXMa4s7 SiQNUmnz2J/15cYK5mj2HO6ZeyTqgUmDsX08NT4UcXgf6YG02tr/JUKFULGd7e9R qu3AO2+HdL+1IB1oymfsLfCdPaoFzvrn9AOfpAJRCW8z64idSugxP+kDUxAfz/4h IS+Q9F2xfltAwigrus+3RxY7iWvh6HuMC52V60BRi1ZegSJ3HHL/Xtkot3PofvjV b3yrNU5pqGaUW30yRAcdUawrluLb5h59TQ17tnWMIKKW8dQ2BD1df1o3dOc6SBEg KGqU1U54n72CDugBk+XalG44AQoAQSiGNJn573lHtRDUm8cABd7VOwUtnz+3i71r Jvhr+p4iNtg37gJJp+Yz =CFLW -----END PGP SIGNATURE----- --nextPart5896559.cj8Jt5EhYd--