From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15221 invoked by alias); 2 Jun 2011 18:24:03 -0000 Received: (qmail 15208 invoked by uid 22791); 2 Jun 2011 18:24:02 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jun 2011 18:23:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p52INnaq007809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Jun 2011 14:23:49 -0400 Received: from host1.jankratochvil.net (ovpn-113-38.phx2.redhat.com [10.3.113.38]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p52INlgI011254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Jun 2011 14:23:48 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p52INkBe025619; Thu, 2 Jun 2011 20:23:46 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p52INj4K025604; Thu, 2 Jun 2011 20:23:45 +0200 Date: Thu, 02 Jun 2011 18:24:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix C++ demangling of minsyms with symver Message-ID: <20110602182345.GA22041@host1.jankratochvil.net> References: <20110602153308.GA21368@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00031.txt.bz2 On Thu, 02 Jun 2011 20:03:45 +0200, Tom Tromey wrote: > I wonder about the other untouched calls to cplus_demangle. I think all the other calls are either for full symtab like TYPE_FN_FIELD_PHYSNAME - which is no longer ever mangled after physname - or for user entered mangled name which will (after the patchset being posted) be found as a fallback in the mangled minsym tables. Just for non-DWARF debug info readers the full symtab can still contain the mangled names. And for DWARF there will be needed some way to find the mangled names anyway (regression PR symtab/12707). So the fix is incomplete for non-DWARF readers but there would be needed first some conclusion on how to fix symtab/12707. Thanks, Jan