From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27431 invoked by alias); 1 Jun 2011 07:08:01 -0000 Received: (qmail 27423 invoked by uid 22791); 1 Jun 2011 07:07:59 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Jun 2011 07:07:42 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5177g3A003502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 03:07:42 -0400 Received: from host1.jankratochvil.net (ovpn-113-38.phx2.redhat.com [10.3.113.38]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5177ett030357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Jun 2011 03:07:41 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p5177dia030539; Wed, 1 Jun 2011 09:07:39 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p5177cVS030538; Wed, 1 Jun 2011 09:07:38 +0200 Date: Wed, 01 Jun 2011 07:08:00 -0000 From: Jan Kratochvil To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: regression: gdb.objc/basicclass.exp [Re: [RFA] "Error in re-setting breakpoint," c++/12750] Message-ID: <20110601070737.GA29856@host1.jankratochvil.net> References: <4DD6B72D.3060706@redhat.com> <4DE568A5.4000306@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DE568A5.4000306@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00001.txt.bz2 On Wed, 01 Jun 2011 00:16:05 +0200, Keith Seitz wrote: > On 05/31/2011 01:58 PM, Tom Tromey wrote: > >>>>>>"Keith" == Keith Seitz writes: > > > >Keith> PR c++/12750 > >Keith> * linespec.c (get_search_block): New function. > [snip] > >Keith> 2010-05-18 Keith Seitz > >Keith> PR c++/12750 > >Keith> * gdb.cp/static-method.cc: New file. > >Keith> * gdb.cp/static-method.exp: New file. > > > >Ok. > > Committed. Thank you for reviewing this patch. -PASS: gdb.objc/basicclass.exp: resetting breakpoints when rerunning -PASS: gdb.objc/basicclass.exp: continue until method breakpoint -PASS: gdb.objc/basicclass.exp: print an ivar of self -PASS: gdb.objc/basicclass.exp: print self -PASS: gdb.objc/basicclass.exp: print contents of self +FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning +FAIL: gdb.objc/basicclass.exp: continue until method breakpoint (GDB internal error) +FAIL: gdb.objc/basicclass.exp: print an ivar of self +FAIL: gdb.objc/basicclass.exp: print self +FAIL: gdb.objc/basicclass.exp: print contents of self 835cf7647bf08d33e2c7286b45658cc58704b363 is the first bad commit commit 835cf7647bf08d33e2c7286b45658cc58704b363 Author: Keith Seitz Date: Tue May 31 22:13:51 2011 +0000 PR c++/12750 * linespec.c (get_search_block): New function. (find_methods): Add FILE_SYMTATB parameter and use it and get_search_block to pass an appropriate block to lookup_symbol_in_namespace. (decode_line_1): Record if *ARGPTR is single-quote enclosed. Check if *ARGPTR starts with a filename first. If it does, call locate_first_half again to locate the next "first half" of the linespec. Pass FILE_SYMTATB to decode_objc and decode_compound. Swallow the trailing single-quote if IS_SQUOTE_ENCLOSED. (locate_first_half): Stop on the first colon seen. (decode_compound): Add FILE_SYMTAB parameter. Pass FILE_SYMTAB to lookup_prefix_sym and find_method. (lookup_prefix_sym): Add FILE_SYMTAB parameter and use get_search_block with lookup_symbol. (find_method): Add FILE_SYMTAB parameter and pass it to find_methods. (decode_objc): Use get_search_block. on {x86_64,x86_64-m32,i686}-fedora{13,14,15,rawhide}-linux-gnu (all the tested platforms). Regards, Jan