Re: ping: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)

Philippe Waroquiers
2011-06-05T20:55:17Z

>> Note that one other thing that I find confusing in the current behaviour
>> is that if you have a certain set of hw watchpoints that were accepted
>> and you add a new one, you might obtain an error back referencing
>> an "old" accepted watchpoint.
>>
>> I think it would be better if the watchpoints would always be re-inserted
>> by gdb in the same order.
>
> I suppose that if we made insert_breakpoint_locations
> walk breakpoints by increasing number instead of walking by
> breakpoint locations, it'd be good enough.

Yes, I think this is avoiding the strange behaviour of having
an error on a previously accepted watchpoint.
If breakpoint always-inserted is on, then I thinkl the error will appear immediately,
which is also ok.

Thanks for the patch to fix the 'busy' debug register on x86, I should be able
to evaluate it end of this week.

Philippe