Re: ping: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)

Pedro Alves
2011-05-31T17:31:16Z

On Monday 30 May 2011 05:06:09, Yao Qi wrote:
> > I can't say I understand why was that being proposed in this case?
> > What is the patch breaking?
> >
>
> One new command "set remote hardware-watchpoint-length-limit"
> is added in the patch, which is only useful to gdbserver+valgrind.
> When gdb is talking with normal gdbserver, it may be wrong to set
> hardware-watchpoint-length-limit in gdb side. Users should be careful
> when using this command.

If that was the only problem, than it'd be okay --- the user just
shouldn't use the command then. GDB will just do what the
user told it to. But, it looks like the patch changes the
behavior _even_ if the user doesn't use the command.

> The ideal solution, IMO, is remote side gives GDB the value of
> hardware-watchpoint-length-limit, however, I don't know it is easy or
> hard to do such thing.

We've also discussed completely getting rid of watchpoint
resources accounting recently.

--
Pedro Alves