From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12377 invoked by alias); 27 May 2011 17:54:03 -0000 Received: (qmail 12368 invoked by uid 22791); 27 May 2011 17:54:03 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 17:53:48 +0000 Received: (qmail 15450 invoked from network); 27 May 2011 17:53:47 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 May 2011 17:53:47 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot Date: Fri, 27 May 2011 17:54:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Tom Tromey , Marek Polacek , Mike Frysinger , toolchain-devel@blackfin.uclinux.org References: <1306440200-25087-1-git-send-email-vapier@gentoo.org> <4DDEB387.3000509@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105271853.44920.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00644.txt.bz2 On Friday 27 May 2011 18:47:49, Tom Tromey wrote: > >>>>> "Marek" == Marek Polacek writes: > > Marek> BTW, couldn't be those strcat()s replaced by, e.g., cheaper mempcpy()? > > Thanks for noticing this. > > Normally my preference is to prefer the simplest code unless it is known > to be performance-critical. In a case like this I doubt that it > matters. And mempcpy is not portable --- we'd have to pull it from gnulib. -- Pedro Alves